Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: update build file #289

Merged
merged 1 commit into from
Apr 17, 2023
Merged

chore: update build file #289

merged 1 commit into from
Apr 17, 2023

Conversation

gablaxian
Copy link
Contributor

No description provided.

@gablaxian gablaxian requested a review from a team as a code owner April 17, 2023 15:27
jgresty
jgresty approved these changes Apr 17, 2023
View reviewed changes
Copy link
Member

@jgresty jgresty left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is surprising we did not catch this in CI, looks like we aren't even running the tests in this directory...

love-bhardwaj
love-bhardwaj approved these changes Apr 17, 2023
View reviewed changes
Copy link
Contributor

@love-bhardwaj love-bhardwaj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggestion/nit: add makefile tidy command that updates both the root module and this 🙂

@gablaxian gablaxian merged commit 324d44d into main Apr 17, 2023
@gablaxian gablaxian deleted the chore/update-build-file branch April 17, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jgresty jgresty jgresty approved these changes

@love-bhardwaj love-bhardwaj love-bhardwaj approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gablaxian @jgresty @love-bhardwaj