Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should deleted and added files be highlighted too? #253

Closed
stevemao opened this issue Jul 20, 2017 · 5 comments
Closed

Should deleted and added files be highlighted too? #253

stevemao opened this issue Jul 20, 2017 · 5 comments

Comments

@stevemao
Copy link
Member

currently only renamed files are highlighted. Would it be better to highlight deleted and added files too?

A side note we should also update the screenshot to show highlighting in the filenames!
@scottchiefbaker
Copy link
Contributor

Like make added files list in green, and deleted files in red?

@stevemao
Copy link
Member Author

stevemao commented Jul 20, 2017 via email

@scottchiefbaker
Copy link
Contributor

Something like this?

adddel

@stevemao
Copy link
Member Author

👍
What do you think?

@scottchiefbaker
Copy link
Contributor

I like it... it's consistent with file renames this way. These screen shots show how #252 will look.

scottchiefbaker added a commit to scottchiefbaker/diff-so-fancy that referenced this issue Jul 20, 2017
@scottchiefbaker
Colorize file add/deletes (so-fancy#253)
5c96bdd
@stevemao stevemao mentioned this issue Jul 26, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@scottchiefbaker @stevemao