update-deps: Fix DiffHighlight's URL and refactor #260
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like I'm the only one who tries to use
update-deps.sh
, huh?This time there were two different problems:
diff-highlight
was made a.pm
so the old URL doesn't point to a valid endpoint.diff-highlight
/DiffHighlight
is no longer expected to be found locally inthird-party
, but inlib
. I guess that's someperl
or at leastfatpack
convention for where local modules should be placed.A word of warning, though: Unlike this repo's version of
DiffHighlight
, the current git-contrib version ofDiffHighlight
doesn'tuse Encode
.This means that after an update & rebuild (fatpack),
diff-so-fancy
will fail (here) unless it has its ownuse Encode
.Source: It bit me. :/