Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dim and underline as Select Graphic Rendition #442

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

utix
Copy link
Contributor

@utix utix commented Sep 12, 2022

first frag with dim
second func with ul

image

configs:

[color "diff"]
        meta = 11
        frag = yellow dim
        old = red bold
        new = green bold
        func = brightyellow
        commit = yellow bold
        whitespace = red reverse
[color "diff"]
        meta = 11
        frag = yellow
        old = red bold
        new = green bold
        func = brightyellow ul
        commit = yellow bold
        whitespace = red reverse

@scottchiefbaker
Copy link
Contributor

The lines that remove the ul/dim from the array aren't necessary because it's handled right after the code for reverse. Remove those two lines and I'll land this.

@scottchiefbaker
Copy link
Contributor

Repurposing my comment from another thread so it's documented in both places:

Just an FYI we purposely did not implement all the Git specific color wordings. There are too many, and the idiosyncrasies were too much to bother with. I'm not against adding some of them in, but we need to be aware the demand for some of these corner cases has been about zero (until this PR).

This one looks simple enough though, so I'll land it.

@scottchiefbaker scottchiefbaker merged commit 483d517 into so-fancy:next Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants