Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Bias Subtract Wrapper #317

Merged
merged 23 commits into from Mar 12, 2020
Merged

Add Bias Subtract Wrapper #317

merged 23 commits into from Mar 12, 2020

Conversation

simontorres
Copy link
Member

The goal of this is to have a consistent simpler process across all apps that use the goodman pipeline as a library

@coveralls
Copy link

coveralls commented Mar 10, 2020 •
edited

Pull Request Test Coverage Report for Build 562

  • 90 of 90 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+2.8%) to 83.071%
Totals Coverage Status
Change from base Build 547: 2.8%
Covered Lines: 3821
Relevant Lines: 4385
💛 - Coveralls

Simon Torres added 22 commits March 10, 2020 16:32
Added docstrings.
45941aa
Added test for no comparison lamp.
58178db
Test for NoMatchFound raised when no reference lamp is found
de3dc19
Moved serial and parallel bining definition (extraction from header) …
d0f0f11 
…to the method _automatic_wavelenth_calibration instead of __call__ where was not used.
refactored test
2f33f14
Renamed unused variable in test for create_master_bias
baedc92
Created test for when there is one solution
26233a9
Removed unused variable in test for create_master_bias
c14379f
Created test for when there is one solution
8b143c3
adding pip freeze
50f58f0
Merge remote-tracking branch 'origin/add_bias_subtract_wrapper' into …
91e51ce 
…add_bias_subtract_wrapper
Setting scipy version 1.3.3 due to a bug un latest 1.4.1
9ba1e34
Setting scipy version 1.3.1 due to a bug un latest 1.4.1
36a1fdf
changing travis configuration
d0c4dde
changed scipy version in the right place.
63e8974
added no test keywords to plotting code.
65837d6
Added test with two reference lamps.
642a75d
Added tests for reference folders
2cee2b1
Added tests for destination folder
6dfcef7
Added a test for __call__ method.
2718fe8
Added a test for goodman_ccd's __call__ method.
6224b98
Added a test for goodman_ccd's --version argument, and removed unused…
1833d49 
… lines
@simontorres simontorres merged commit f0e050e into soar-telescope:master Mar 12, 2020
@simontorres simontorres deleted the add_bias_subtract_wrapper branch March 12, 2020 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simontorres @coveralls