submit git-secret for inclusion in EPEL/fedora

[joshrabinowitz]

I think git-secret should be considered for inclusion into EPEL / fedora:

Someone would have to go through this process, or already have gone through it.

https://fedoraproject.org/wiki/Join_the_package_collection_maintainers

Volunteers sought!

[joshrabinowitz]

@hurricanehrndz is this something you know how to do?

[gombosg]

Hi, I just stumbled upon this. I'm making the specfile and will submit it for review soon.

[gombosg]

Yay: https://bugzilla.redhat.com/show_bug.cgi?id=1685270

[sobolevn]

@gombosg awesome 👍

[joshrabinowitz]

Yes thank you @gombosg !

We just got feedback on https://bugzilla.redhat.com/show_bug.cgi?id=1685270 , things look pretty good for git-secret but we got some feedback:

- Not needed:

rm -rf $RPM_BUILD_ROOT

 - there's a zsh completion script git-secret.plugin.zsh, install it 
   (don't forget to own the dirs)

 - Use a  better name for your archive:
Source0: https://github.com/sobolevn/%{name}/archive/v%{version}/%{name}-%{version}.tar.gz

I'll write up issues for the above items.

Also git-secret was failed on one thing:
[!]: Uses parallel make %{?_smp_mflags} macro.
Not sure what to do about this.

Edit: Also, this:

Issues:
=======
- Package uses either %{buildroot} or $RPM_BUILD_ROOT
  Note: Using both %{buildroot} and $RPM_BUILD_ROOT
  See: http://fedoraproject.org/wiki/Packaging/Guidelines#macros

[gombosg]

That was some quick feedback fortunately. 😄 These are probably only my packaging issues so no need to create separate issues here if they don't affect the upstream package. I'm going to correct them and then we're all good.

[joshrabinowitz]

@gombosg ok sounds great! Feel free to close the above bugs 'per #315' after they're corrected, or let us know if some change is required in git-secret.

[gombosg]

I can't close the bugs because I didn't open them and I don't have maintainer rights here. 😄
Corrected the issues, you can delete the ZSH installer later since it's deprecated and apparently confused package reviewers, too.

[joshrabinowitz]

@gombosg all sounds good.

Can you please leave a comment in each bug above that's still open and should be closed, requesting we close (ideally with a link to the fix), and I'll close them?

Want to make sure I don't close them prematurely. Thank you!

[gombosg]

Okay, so package approved, built for rawhide (rolling "next" release), here are the F29 and F30 updates.

The updates will be approved after 7 days or if enough people test it and give some good karma at the above links. 🙂

As for EPEL, I never used RHEL or CentOS but if the package works OK in Fedora I might simply request a branch for EL7, but for some weird reason the scratch build fails there - not the build but setting up the environment so it may not be a packaging issue. I'm looking into it.

EDIT: yes, for EL7 there's a build root issue, I just got confirmation on IRC.

[joshrabinowitz]

@gombosg what should we do to test it-- just download and install the rpm, and try it out, or more? Is there a repo I should enable that will allow it to be installed with dnf?

I have set up fedora 29 and 30 (aka which is no longer 'rawhide') VMs to test it out with.

[gombosg]

Haha, awesome. Well, just directly install the RPM from the above link or after enabling the updates-testing repo. You can test if it encrypts a file, opens the manpage etc. More instructions here.

It needs 3 karma (3 good test results) to progress, but after 7 days it's automatically approved. Nevertheless, testing never hurts 🙂

I'm excited since I'm a new packager and this is my 2nd package for Fedora.

EDIT: FYI F30 is not rawhide anymore, we're just in that point in time when F30 has been branched from Rawhide but the beta hasn't been released yet. I just got the mail today.

[joshrabinowitz]

Hello @gombosg . I see from https://rpms.remirepo.net/rpmphp/zoom.php?rpm=git-secret that git-secret is in fedora f29 and f30 'testing', and the 'devel' branch. This is exciting progress.

Let us know if there's anything we can do to help move git-secret towards mainline acceptance (I did add one 'karma' point).

Is there a doc that explains the process of a package getting out of 'testing'? I looked but couldn't find one.
Thank you again for helping us get to this point!

[gombosg]

Yep, don't worry I'm taking care of things.
F29 is pushed to batched which means it'll go out with the next batch update (today or tomorrow).
There was some bug with the F30 update, it might take a few more days, but F30 is only beta anyway. I'll ping here when it's all done and the bug can be closed. 🙂

[joshrabinowitz]

That's great, @gombosg . What's the story with getting into EPEL?

[gombosg]

Once git-secret is in the main Fedora repos and we see that it's OK, I'll request an EPEL branch and do koji builds for it. Then we'll all test it in CentOS VMs to see if it's actually working. 🙂

[gombosg]

Type git-secret into a Fedora command line and now the package should install. I suggest waiting a few weeks for some test input from users, then go for EPEL.

[gombosg]

I have requested EPEL branches, here are some scratch builds - worked for me in a VM, testing is welcome!
http://koji.fedoraproject.org/koji/taskinfo?taskID=36829936
http://koji.fedoraproject.org/koji/taskinfo?taskID=36829941

[gombosg]

Ok, here are the Bodhi updates:
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-2261827101
https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2019-5578d0c2fa
Enjoy!

[gombosg]

It's also in EPEL now! For EL7 and EL8.
https://apps.fedoraproject.org/packages/git-secret
You can close this issue for now.

[sobolevn]

Awesome! Thanks a lot, @gombosg! 🎉