Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove (not install) git-secret.plugin.zsh script as per #315 #382

Closed
joshrabinowitz opened this issue Mar 5, 2019 · 3 comments
Closed

remove (not install) git-secret.plugin.zsh script as per #315 #382

joshrabinowitz opened this issue Mar 5, 2019 · 3 comments
Assignees
@joshrabinowitz
Labels
build test release improvements to buid, test or release help wanted

Comments

@joshrabinowitz
Copy link
Collaborator

  • there's a zsh completion script git-secret.plugin.zsh, install it
    (don't forget to own the dirs)

See #315
@joshrabinowitz joshrabinowitz added help wanted build test release improvements to buid, test or release labels Mar 5, 2019
@joshrabinowitz joshrabinowitz changed the title install zsh completion script as per #315 install git-secret.plugin.zsh script as per #315 Mar 5, 2019
@joshrabinowitz
Copy link
Collaborator Author

Should we just remove the file at
https://github.com/sobolevn/git-secret/blob/79a1c45aeb3585a132c6fe3e9eb3974614ec4573/git-secret.plugin.zsh ?

@gombosg
Copy link
Contributor

gombosg commented Mar 5, 2019

It's not included in install.sh so yeah, safe to remove in a next release.

@sobolevn
Copy link
Owner

sobolevn commented Mar 5, 2019

Yeap, let's remove it.

@joshrabinowitz joshrabinowitz mentioned this issue Mar 5, 2019
Merged
@joshrabinowitz joshrabinowitz changed the title install git-secret.plugin.zsh script as per #315 remove (not install) git-secret.plugin.zsh script as per #315 Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joshrabinowitz joshrabinowitz

Labels
build test release improvements to buid, test or release help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshrabinowitz @sobolevn @gombosg