Fix tests when run from git hooks

[joshrabinowitz]

CONTRIBUTING.md says to use make install-hooks to install pre- and post-commit hooks, but if you do that then the self-tests fail on commit:

% # make a meaningless, whitespace change to a file in src/commands/
% git commit -a
1..88
ok 1 run 'add' normally
ok 2 run 'add' for unignored file

...

ok 27 run 'hide' with '-P'
not ok 28 run 'hide' from inside subdirectory
# (in test file /home/joshr/gitsrc/git-secret/tests/test_hide.bats, line 88)
#   `[ "$status" -eq 0 ]' failed
# rm: cannot remove ‘space file’: No such file or directory
# fatal: Not a git repository: '.git'
# find: ‘/tmp/tmp.aBlVDAbUQF’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-rtkit-daemon.service-KNfvrc’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-colord.service-ivZa8u’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-fwupd.service-07aFP3’: Permission denied
# find: ‘/tmp/tmp.UbZvBTtYAa’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-chronyd.service-G1ov1r’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-cups.service-kAx3OS’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-bolt.service-IZaN9N’: Permission denied
# find: ‘/tmp/tmp.1L9d7x7l3I’: Permission denied
not ok 29 run 'hide' with missing file
# (from function `set_state_secret_init' in file /home/joshr/gitsrc/git-secret/tests/_test_base.bash, line 202,
#  from function `setup' in test file /home/joshr/gitsrc/git-secret/tests/test_hide.bats, line 14)
#   `set_state_secret_init' failed
# find: ‘/tmp/tmp.aBlVDAbUQF’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-rtkit-daemon.service-KNfvrc’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-colord.service-ivZa8u’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-fwupd.service-07aFP3’: Permission denied
# find: ‘/tmp/tmp.UbZvBTtYAa’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-chronyd.service-G1ov1r’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-cups.service-kAx3OS’: Permission denied
# find: ‘/tmp/systemd-private-8b7dddc415874f87ad46f53ff94b4d7f-bolt.service-IZaN9N’: Permission denied
# find: ‘/tmp/tmp.1L9d7x7l3I’: Permission denied
ok 30 run 'hide' with multiple files

...
```

[sobolevn]

@joshrabinowitz that's why I had this solution:

git-secret/tests/test_add.bats

Lines 71 to 76 in d5c138a

	# This test covers this issue:
	# https://github.com/sobolevn/git-secret/issues/85 task 1
	if [[ "$BATS_RUNNING_FROM_GIT" -eq 1 ]]; then
	skip "this test is skipped while 'git commmit'"
	fi

[joshrabinowitz]

@sobolevn but.... why does running under a 'git commit' fail?

Is there a better fix for this that doesn't require disabling the test in that situation?

[sobolevn]

That's some deep git magic about its internal state: it is obviously different in normat mode and "commiting" state. I am not sure how different it is, however. And I was not able to find the correct solution back then.

[joshrabinowitz]

For clarity, the issue is related to git rev-parse not working as expected when run from this pre-commit githook:

git-secret/utils/hooks/pre-commit.sh

Line 16 in 26ecd39

make test

calls to rev-parse are here:

git-secret/src/_utils/_git_secret_tools.sh

Line 331 in 26ecd39

result=$(git rev-parse --is-inside-work-tree > /dev/null 2>&1; echo $?)

and

git-secret/src/_utils/_git_secret_tools.sh

Line 354 in 26ecd39

result=$(git rev-parse --show-toplevel)