-
-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rethink internal 'design' of git-secret #333
Labels
Comments
Maybe we can ask @jirutka directly about what can be improved? |
See #319 |
See also https://wiki.debian.org/UpstreamGuide (mentioned in #312 ) |
I think one thing people think is weird is concatenating the sources together into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
There's some things about git-secret's build system that are weird
(one packager called git-secret 'very badly designed')
Let's make a list of things that could be clearer/simpler/more consistent with typical packaging:
don't: append multiple files together from src/ to create a single git-secret script
** If we're going to append all the files together anyway, perhaps we should just have them that way in git
setting up the temp directory used for testing git-secret
** if you try to run the git-secret tests manually from the git checkout (IE without using the Makefile), everything goes haywire
if a test fails, a weird string of 'find' errors might get output, see Fix tests when run from git hooks #334
other things? Ideas for improved architecture/packaging of git-secret welcome.
The text was updated successfully, but these errors were encountered: