_user_required had a serious bug #74
Comments
sobolevn
added a commit
that referenced
this issue
Feb 26, 2017
There are a lot of changes, multiple things were refactored: tests, some commands, building and meta. Several critical bugs fixed. Changes: 1. Fixed #74, when `_user_required` was not working after reimporting keys 2. Closes #73, now it is possible to provide multiple emails to the `killperson` command 3. Closes #72, now it is possible to provide multiple emails to the `tell` command 4. Closes #71, now every doc in this project refer to `git-secret.io` instead of old `gh-pages` website 5. Closes #70, now installation section is removed from main `man` file 6. Closes #69, now "See also" section in the `man`s are clickable 7. Closes #61, added "Manual" section to the manuals 8. Closes #38, added `centos` container for `ci` testing 9. Refs #52, tests are refactored. Added `clean` command tests, removed a lot of hardcoded things, moved tests execution from `./temp` folder to `/tmp`, added a lot of new check in old tests, and some new test cases 10. Refactored `hide` and `clean` commands to be shorter 11. `shellcheck` is now supported with `make lint` Additional features are not comming to 0.2.2 after this commit.
sobolevn
added a commit
that referenced
this issue
Feb 26, 2017
There are a lot of changes, multiple things were refactored: tests, some commands, building and meta. Several critical bugs fixed. Changes: 1. Fixed #74, when `_user_required` was not working after reimporting keys 2. Closes #73, now it is possible to provide multiple emails to the `killperson` command 3. Closes #72, now it is possible to provide multiple emails to the `tell` command 4. Closes #71, now every doc in this project refer to `git-secret.io` instead of old `gh-pages` website 5. Closes #70, now installation section is removed from main `man` file 6. Closes #69, now "See also" section in the `man`s are clickable 7. Closes #61, added "Manual" section to the manuals 8. Refs #38, added `centos` Dockerfile, but `ci` testing is still failing 9. Refs #52, tests are refactored. Added `clean` command tests, removed a lot of hardcoded things, moved tests execution from `./temp` folder to `/tmp`, added a lot of new check in old tests, and some new test cases 10. Refactored `hide` and `clean` commands to be shorter 11. `shellcheck` is now supported with `make lint` Additional features are not comming to 0.2.2 after this commit.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
What are the steps to reproduce this issue?
git secret addcommandgit secret removecommandWhat happens?
A lot of bad things happen.
What were you expecting to happen?
Error must be generated.
What versions of software are you using?
git-secretversion: 0.2.1Any functions which were using
_user_requiredare affected.This bug is already fixed. It will be covered with the test case in the closes commit.
Fixed by changing
keys_exist=$($GPGLOCAL -n --list-keys --with-colon)tokeys_exist=$($GPGLOCAL -n --list-keys)The text was updated successfully, but these errors were encountered: