Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Verbose env var #393

Merged
merged 23 commits into from
Mar 7, 2019
Merged

Verbose env var #393

merged 23 commits into from
Mar 7, 2019

Conversation

joshrabinowitz
Copy link
Collaborator

@joshrabinowitz joshrabinowitz commented Mar 6, 2019 •
edited
Loading

Closes #323
Closes #394

@joshrabinowitz joshrabinowitz mentioned this pull request Mar 7, 2019
Closed
@joshrabinowitz
Copy link
Collaborator Author

joshrabinowitz commented Mar 7, 2019 •
edited
Loading

@sobolevn I think this is about ready to merge after some documentation additions. (Edit: And maybe some more tests.)

Any other verbosity-related changes (like #395) I'd like to put in a separate PR.

Let me know if you have any feedback.

@joshrabinowitz joshrabinowitz mentioned this pull request Mar 7, 2019
Closed
@joshrabinowitz
Copy link
Collaborator Author

joshrabinowitz commented Mar 7, 2019 •
edited
Loading

Yeah I think this is ready to squash and merge.

Let me do the squash-merge because I want to edit the commit message to match the one squashed commit.

@joshrabinowitz joshrabinowitz merged commit 22fe1ed into sobolevn:master Mar 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn Awaiting requested review from sobolevn

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@joshrabinowitz