Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eslint -> oxlint #26

Merged
merged 4 commits into from Dec 16, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
18 changes: 18 additions & 0 deletions CHANGES.md
Expand Up @@ -12,6 +12,24 @@ Here you can find project-wide changes. For more detailed changes:
### Breaking changes

- Move to `vite` (#8)
- Move from `eslint` to `oxc` (#26)

With eslint:

```
Benchmark 1: yarn lint
Time (mean ± σ): 7.734 s ± 0.119 s [User: 10.668 s, System: 1.393 s]
Range (min … max): 7.559 s … 7.902 s 10 runs
```

With oxc:

```
Benchmark 1: yarn lint
Time (mean ± σ): 5.284 s ± 0.106 s [User: 6.894 s, System: 1.065 s]
Range (min … max): 5.155 s … 5.476 s 10 runs
```

- Run prettier across full codebase (#9)

- Add docs/ to formatting
Expand Down
8 changes: 1 addition & 7 deletions package.json
Expand Up @@ -33,18 +33,12 @@
]
},
"dependencies": {
"eslint": "^8.56.0",
"typescript": "^5.3.3"
},
"devDependencies": {
"@ianvs/prettier-plugin-sort-imports": "^4.1.1",
"@typescript-eslint/eslint-plugin": "^6.14.0",
"@typescript-eslint/parser": "^6.14.0",
"cross-env": "^7.0.3",
"eslint-plugin-import": "^2.29.1",
"eslint-plugin-node": "^11.1.0",
"eslint-plugin-promise": "^6.1.1",
"eslint-plugin-tsc": "^2.0.0",
"oxlint": "^0.0.20",
"prettier": "^3.1.1",
"prettier-plugin-css-order": "^2.0.1"
},
Expand Down
6 changes: 6 additions & 0 deletions packages/lib/CHANGES.md
Expand Up @@ -13,6 +13,12 @@ description: Latest updates for the @social-embed URL parsing library.

- Limit URL lengths for Loom, EdPuzzle, and Wistia

### Development

- Move from `eslint` to `oxc` (#26)

Faster linting, as it is rust-based.

## 0.1.0-next.7 (2023-11-25)

### Breaking changes
Expand Down
4 changes: 2 additions & 2 deletions packages/lib/package.json
Expand Up @@ -44,14 +44,14 @@
"prepare": "yarn build",
"bootstrap": "echo 'NOOP'",
"test": "vitest",
"lint": "eslint src",
"lint": "oxlint",
"ncu": "ncu",
"update": "ncu",
"prettier": "prettier",
"format": "yarn run prettier . --write"
},
"devDependencies": {
"eslint-plugin-redos-detector": "^2.4.0",
"oxlint": "^0.0.20",
"typescript": "^5.3.3",
"vite": "^5.0.10",
"vite-plugin-dts": "^3.6.4",
Expand Down
3 changes: 2 additions & 1 deletion packages/site/package.json
Expand Up @@ -36,8 +36,9 @@
},
"devDependencies": {
"@docusaurus/module-type-aliases": "3.0.1",
"@docusaurus/types": "3.0.1",
"@docusaurus/tsconfig": "^3.0.1",
"@docusaurus/types": "3.0.1",
"oxlint": "^0.0.20",
"typescript": "^5.3.3"
},
"browserslist": {
Expand Down
4 changes: 4 additions & 0 deletions packages/wc/CHANGES.md
Expand Up @@ -37,6 +37,10 @@ description: Latest updates for the @social-embed web component.
- https://github.com/vitejs/vite/blob/v5.0.0/packages/vite/CHANGELOG.md
- https://github.com/vitejs/vite/blob/531d3cb/packages/vite/CHANGELOG.md

- Move from `eslint` to `oxc` (#26)

Faster linting, as it is rust-based.

## 0.0.1-next.7 (2023-11-11)

### Improvements
Expand Down
8 changes: 3 additions & 5 deletions packages/wc/package.json
Expand Up @@ -21,8 +21,8 @@
"clean": "rimraf dist/",
"ncu": "ncu",
"update": "ncu",
"lint": "npm run lint:lit-analyzer && npm run lint:eslint",
"lint:eslint": "eslint 'src/**/*.ts'",
"lint": "npm run lint:lit-analyzer && npm run lint:oxlint",
"lint:oxlint": "oxlint",
"lint:lit-analyzer": "lit-analyzer -- --rules.no-boolean-in-attribute-binding off --rules.no-incompatible-type-binding off --rules.no-unknown-attribute off",
"prettier": "prettier",
"format": "yarn run prettier . --write",
Expand Down Expand Up @@ -58,16 +58,14 @@
},
"devDependencies": {
"@open-wc/testing": "^4.0.0",
"@typescript-eslint/eslint-plugin": "^6.14.0",
"@typescript-eslint/parser": "^6.14.0",
"@web/dev-server-esbuild": "^1.0.1",
"@web/dev-server-import-maps": "^0.2.0",
"@web/test-runner": "^0.18.0",
"@web/test-runner-puppeteer": "^0.15.0",
"chai": "^4.3.10",
"deepmerge": "^4.3.1",
"eslint": "^8.56.0",
"lit-analyzer": "^2.0.2",
"oxlint": "^0.0.20",
"rimraf": "^5.0.5",
"typescript": "^5.3.3",
"vite": "^5.0.10",
Expand Down