biome #27
Merged
biome #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tony
force-pushed
the
biome
branch
2 times, most recently
from
b9b4cce
to
5b458dc
Compare
./packages/site/src/pages/index.tsx:135:33 lint/suspicious/noArrayIndexKey ━━━━━━━━━━━━━━━━━━━━━━━━━
✖ Avoid using the index of an array as key property in an element.
133 │ <div className="row">
134 │ {features.map((props, idx) => (
> 135 │ <Feature key={idx} {...props} />
│ ^^^
136 │ ))}
137 │ </div>
ℹ This is the source of the key value.
132 │ <div className="container">
133 │ <div className="row">
> 134 │ {features.map((props, idx) => (
│ ^^^
135 │ <Feature key={idx} {...props} />
136 │ ))}
.vscode/extensions.json:2:3 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ Expected a property but instead found '// See https://go.microsoft.com/fwlink/?LinkId=827846 to learn about workspace recommendations.'. 1 │ { > 2 │ // See https://go.microsoft.com/fwlink/?LinkId=827846 to learn about workspace recommendations. │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 3 │ // Extension identifier format: ${publisher}.${name}. Example: vscode.csharp 4 │ ℹ Expected a property here. 1 │ { > 2 │ // See https://go.microsoft.com/fwlink/?LinkId=827846 to learn about workspace recommendations. │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 3 │ // Extension identifier format: ${publisher}.${name}. Example: vscode.csharp 4 │ .vscode/extensions.json:6:3 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ End of file expected 5 │ // List of extensions which should be recommended for users of this workspace. > 6 │ "recommendations": ["runem.lit-plugin"], │ ^^^^^^^^^^^^^^^^^ 7 │ // List of extensions recommended by VS Code that should not be recommended for users of this workspace. 8 │ "unwantedRecommendations": [] ℹ Use an array for a sequence of values: `[1, 2]` .vscode/extensions.json:6:20 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ End of file expected 5 │ // List of extensions which should be recommended for users of this workspace. > 6 │ "recommendations": ["runem.lit-plugin"], │ ^ 7 │ // List of extensions recommended by VS Code that should not be recommended for users of this workspace. 8 │ "unwantedRecommendations": [] ℹ Use an array for a sequence of values: `[1, 2]` .vscode/extensions.json:6:22 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ End of file expected 5 │ // List of extensions which should be recommended for users of this workspace. > 6 │ "recommendations": ["runem.lit-plugin"], │ ^^^^^^^^^^^^^^^^^^^^ 7 │ // List of extensions recommended by VS Code that should not be recommended for users of this workspace. 8 │ "unwantedRecommendations": [] ℹ Use an array for a sequence of values: `[1, 2]` .vscode/extensions.json:6:42 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ End of file expected 5 │ // List of extensions which should be recommended for users of this workspace. > 6 │ "recommendations": ["runem.lit-plugin"], │ ^ > 7 │ // List of extensions recommended by VS Code that should not be recommended for users of this workspace. │ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 8 │ "unwantedRecommendations": [] 9 │ } ℹ Use an array for a sequence of values: `[1, 2]` .vscode/extensions.json:8:3 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ End of file expected 6 │ "recommendations": ["runem.lit-plugin"], 7 │ // List of extensions recommended by VS Code that should not be recommended for users of this workspace. > 8 │ "unwantedRecommendations": [] │ ^^^^^^^^^^^^^^^^^^^^^^^^^ 9 │ } 10 │ ℹ Use an array for a sequence of values: `[1, 2]` .vscode/extensions.json:8:28 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ End of file expected 6 │ "recommendations": ["runem.lit-plugin"], 7 │ // List of extensions recommended by VS Code that should not be recommended for users of this workspace. > 8 │ "unwantedRecommendations": [] │ ^ 9 │ } 10 │ ℹ Use an array for a sequence of values: `[1, 2]` .vscode/extensions.json:8:30 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ End of file expected 6 │ "recommendations": ["runem.lit-plugin"], 7 │ // List of extensions recommended by VS Code that should not be recommended for users of this workspace. > 8 │ "unwantedRecommendations": [] │ ^^ 9 │ } 10 │ ℹ Use an array for a sequence of values: `[1, 2]` .vscode/extensions.json:9:1 parse ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━ ✖ End of file expected 7 │ // List of extensions recommended by VS Code that should not be recommended for users of this workspace. 8 │ "unwantedRecommendations": [] > 9 │ } │ ^ 10 │ ℹ Use an array for a sequence of values: `[1, 2]`
yarn biome lint packages/wc/test/o-embed_test.ts
yarn run v1.22.19
$ biome lint packages/wc/test/o-embed_test.ts
packages/wc/test/o-embed_test.ts:155:22 lint/style/noNonNullAssertion ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
✖ Forbidden non-null assertion.
153 │ html`<o-embed url=${src}></o-embed>`,
154 │ )) as OEmbedElement;
> 155 │ const iframe = el.shadowRoot?.querySelector("iframe")!;
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
156 │ iframe.click();
157 │ await el.updateComplete;
packages/wc/test/o-embed_test.ts:353:22 lint/style/noNonNullAssertion ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
✖ Forbidden non-null assertion.
351 │ html`<o-embed url=${src}></o-embed>`,
352 │ )) as OEmbedElement;
> 353 │ const iframe = el.shadowRoot?.querySelector("iframe")!;
│ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
354 │ iframe.click();
355 │ await el.updateComplete;
packages/wc/test/o-embed_test.ts lint ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
✖ The file contains diagnostics that needs to be addressed.
Checked 1 file(s) in 2ms
Found 3 error(s)
lint ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
./packages/lib/src/utils.ts:53:49 lint/suspicious/noExplicitAny ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
✖ Unexpected any. Specify a different type.
51 │ type ProviderIdFn = {
52 │ // eslint-disable-next-line @typescript-eslint/no-explicit-any
> 53 │ [P in ValueOfProvider]: (id: string, ...args: any[]) => string;
│ ^^^
54 │ };
55 │
ℹ any disables many type checking rules. Its use should be avoided.
./packages/lib/src/utils.ts lint ━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━━
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is so fast, and the tooling is so good, I am 💫