Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Redis keys command is evil #35

Merged
merged 1 commit into from
Feb 8, 2015
Merged

Redis keys command is evil #35

merged 1 commit into from
Feb 8, 2015

Conversation

felipeclopes
Copy link
Contributor

Removed keys command that are used in Superworker execution.

This should improve performance as well as start the support to redis clusters.

@felipeclopes
Copy link
Contributor Author

bump!

@felipeclopes
Copy link
Contributor Author

No response on this?

tombenner added a commit that referenced this pull request Feb 8, 2015
@tombenner
Merge pull request #35 from felipeclopes/master
443ebec 
Redis keys command is evil
@tombenner tombenner merged commit 443ebec into socialpandas:master Feb 8, 2015
@tombenner
Copy link
Contributor

Great, this is an important improvement! I'll include an upgrade note in the README, and may also rename #{redis_prefix}:#{superjob_id}:members to #{redis_prefix}:#{superjob_id}:subjob_keys for clarity's sake. Many thanks!

@felipeclopes
Copy link
Contributor Author

Welcome! Thank you for supporting this awesome gem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@felipeclopes @tombenner