Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add configuration switch to disable fallback to root directory #88

Merged
merged 1 commit into from
Jan 28, 2024
Merged

add configuration switch to disable fallback to root directory #88

merged 1 commit into from
Jan 28, 2024

Conversation

purnhar
Copy link
Contributor

@purnhar purnhar commented Jan 28, 2024

Summary

Skip analysis for projects without source files

Details

If no source files are found in a module of a multi module project, no analysis should be done (e.g. in modules which just assemble war files or docker images). Therefor a the configuration property fallbackToRootDirectory is added to disable the current default behavior.

Context

Feature is needed in bigger Maven multi module projects.

Checklist:

  • I've added tests for my code.
  • Documentation has been updated accordingly to this PR

Related issue :

societe-generale/arch-unit-maven-plugin#66

@codecov-commenter
Copy link

Codecov Report

Attention: 7 lines in your changes are missing coverage. Please review.

Comparison is base (c3bdbe4) 79.96% compared to head (16f129f) 79.18%.

Files Patch % Lines
...ale/commons/plugin/service/RuleInvokerService.java 22.22% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master      #88      +/-   ##
============================================
- Coverage     79.96%   79.18%   -0.79%     
- Complexity      145      147       +2     
============================================
  Files            33       33              
  Lines           654      663       +9     
  Branches         65       65              
============================================
+ Hits            523      525       +2     
- Misses          104      111       +7     
  Partials         27       27              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincent-fuchs vincent-fuchs merged commit ad5647b into societe-generale:master Jan 28, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants