This repository has been archived by the owner on Jul 28, 2020. It is now read-only.
Dropdown option hover state #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
damian-rodriguez-sociomantic
suggested changes
Oct 26, 2018
There was a problem hiding this comment.
hey @daniel-martic-sociomantic could you double check also font color, distances of the icon information list item and distance of the list category title. According to the issue there are some changes also there, Thanks!!
damian-rodriguez-sociomantic
previously requested changes
Oct 30, 2018
There was a problem hiding this comment.
It looks good to me so far, but still missing some updates, the navigation role sub needs to be updated according to the new specs, also the distance between icon an option text not matching the design in some cases, also the current alignment of the option icon and icon text is different than the specs
daniel-martic-sociomantic
dismissed
damian-rodriguez-sociomantic’s stale review
Added missing styles and fixed sizings
daniel-martic-sociomantic
requested a review
from damian-rodriguez-sociomantic
…mantic-tsunami/nessie-ui into Issue-685-DropdownOptionHoverState
damian-rodriguez-sociomantic
approved these changes
Nov 2, 2018
conor-cafferkey-sociomantic
deleted the
Issue-685-DropdownOptionHoverState
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #685