Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Paging library #61

Closed
tallnato opened this issue Sep 8, 2018 · 13 comments
Closed

Paging library #61

tallnato opened this issue Sep 8, 2018 · 13 comments

Comments

@tallnato
Copy link

tallnato commented Sep 8, 2018

Great work with this lib 👏

Any changes this it will provide compatibility with Android Paging Library from the architecture components?

@sockeqwe
Copy link
Owner

sockeqwe commented Sep 11, 2018 via email

@tallnato
Copy link
Author

I've 'kind of' started doing that in https://github.com/YouClap/AdapterDelegates/tree/paging_lib
But it was a quit (🔨) and ugly implementation, I can create a pull request with it so that you can check it out.

What do you think?

@makarenkoanton
Copy link

Hi, thanks for your lib.
I use your 3.0.2 snapshot, and now not working boundary callback for PageList.
Do you have some roadmap about paging library and your lib?)

@sockeqwe
Copy link
Owner

The plan is the following:

  1. Release 3.1.0 which contains async list differ so that we have the equivalent to ListAdapter from support library (that uses DiffUtil and AsyncListDiffer under the hood). This is already in latest master. However, I wasn't able to upload this to maven central yet because of some signing pgp issues on my new macbook.

  2. Once 1. is solved I will migrate library to jetpack and release it as AdapterDelegates 4.0. This should be very straight forward.

  3. Add support for PageList. This as well should not be a big deal, just a few hours to sit down (or in case someone wants to contribute, PR are welcome).

@sockeqwe
Copy link
Owner

sockeqwe commented Oct 5, 2018

Working on that as a next step. Mabye somewhen next week.

@sockeqwe
Copy link
Owner

sockeqwe commented Oct 15, 2018

Latest 4.0.1-SNAPSHOT contains a PagedListDelegationAdapter. It should work with PagedList as shown in the sample application.
Unfortunately, I wasn't yet able to implement the datasource for the sample application properly (PR is very welcome) but it should work and it would be great if you could give it a try and let me know if it works in your project.

@tallnato
Copy link
Author

tallnato commented Nov 15, 2018

@sockeqwe I was testing that new release and I think you are not deploying the paging library to sonatype 🤔
Probably missing some configs in the deploy_snapshot.sh, no?

I'm tested with Jitpack and from my tests it seems to be ok 👌

@sockeqwe
Copy link
Owner

You are right, there was something missing.

Snapshot is available now.

@akhbulatov
Copy link

@sockeqwe I've added 4.0.1-SNAPSHOT version and not found PagedListDelegationAdapter in the lib

@sockeqwe
Copy link
Owner

sockeqwe commented Mar 7, 2019

It's a second artifact (I messed it up, but for final 4.0.1 version I will clean it up and give it a proper artifact name).

Please try

allprojects {
  repositories {
    ...

    maven { url "https://oss.sonatype.org/content/repositories/snapshots/" }
}
implementation  'com.hannesdorfmann:paging:4.0.1-SNAPSHOT'

@sockeqwe
Copy link
Owner

sockeqwe commented Mar 9, 2019

@akhbulatov did it work for you?

@akhbulatov
Copy link

@sockeqwe yes, it works

@sockeqwe
Copy link
Owner

sockeqwe commented Jul 18, 2019

Latest release: implementation 'com.hannesdorfmann:adapterdelegates4-pagination:4.1.0'

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants