fix the case where done() called multiple times

socketio · Nov 26, 2015 · e55cf32 · e55cf32
1 parent 281bf7e
commit e55cf32
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/test/transport.js b/test/transport.js
@@ -10,12 +10,15 @@ describe('Transport', function () {
       var socket = new eio.Socket();
       expect(socket.transport.name).to.be('polling');
 
+      var timedout = false;
       var timeout = setTimeout(function(){
+        timedout = true;
         socket.close();
         done();
       }, 300);
 
       socket.on('upgrade', function (transport) {
+        if (timedout) return;
         clearTimeout(timeout);
         socket.close();
         if(transport.name == 'websocket') {
@@ -30,12 +33,15 @@ describe('Transport', function () {
       var socket = new eio.Socket();
       expect(socket.transport.name).to.be('polling');
 
+      var timedout = false;
       var timeout = setTimeout(function(){
+        timedout = true;
         socket.close();
         done();
       }, 300);
 
       socket.on('upgrade', function (transport) {
+        if (timedout) return;
         clearTimeout(timeout);
         socket.close();
         if(transport.name == 'websocket') {