New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restoring require('ws') as separate expression for browserify. #418

Merged

darrachequesne merged 1 commit into socketio:master from darrachequesne:patch-2

Aug 5, 2016

Member

darrachequesne commented Aug 4, 2016

Cherry-pick from #397.

Reference #390 (comment)

@rauchg, @kapouer Guys, this PR breaks the ability to pack socket.io / engine.io with browserify because it is not able to detect the module name anymore. I.e. every time require with variable breaks it. I'm going to fix it in #397 to avoid creating a new PR.

Closes #397


          Restoring require('ws') as separate expression for browserify.

9bd8481

darrachequesne merged commit fadeb7d into socketio:master

darrachequesne added this to the 1.7.0 milestone

darrachequesne mentioned this pull request

Try to load uws by default, fall back to ws #459

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet