-
Notifications
You must be signed in to change notification settings - Fork 571
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better pings 2 #84
Better pings 2 #84
Conversation
Thinking about this reminded me of an observation I made when writing this patch. Why are pings initiated by the server? This patch provides the following:
By necessity to accomplish If pings were initiated by client we could get rid of the ack
This would mean more changes to the SPEC and client implementations but is a cleaner and lighter lifecycle. I am leaning towards this approach as I typically always initiate pings on clients. |
Sounds good, since we're changing pings we might as well switch to that. Good point @cadorn |
Done here & socketio/engine.io-client#51 All tests still pass! (other than two minor adjustments) Now only need to update SPEC. |
@cadorn just merged this, looking good. Make sure to submit a PR for SPEC. |
Thanks a lot! |
See #115 for spec. |
This pull-request cleans up the commits for #78.
For previous discussion see: #78