fix: Adapter#encode() is now synchronous

See https://github.com/socketio/socket.io-parser/releases/tag/4.0.0
socketio · Sep 28, 2020 · c043650 · c043650
1 parent 7216d7a
commit c043650
Showing 1 changed file with 19 additions and 19 deletions.
diff --git a/lib/index.ts b/lib/index.ts
@@ -114,28 +114,28 @@ export class Adapter extends EventEmitter {
     const ids = new Set();
 
     packet.nsp = this.nsp.name;
-    this.encoder.encode(packet, encodedPackets => {
-      if (rooms.size) {
-        for (const room of rooms) {
-          if (!this.rooms.has(room)) continue;
-
-          for (const id of this.rooms.get(room)) {
-            if (ids.has(id) || except.has(id)) continue;
-            const socket = this.nsp.connected.get(id);
-            if (socket) {
-              socket.packet(encodedPackets, packetOpts);
-              ids.add(id);
-            }
-          }
-        }
-      } else {
-        for (const [id] of this.sids) {
-          if (except.has(id)) continue;
+    const encodedPackets = this.encoder.encode(packet);
+
+    if (rooms.size) {
+      for (const room of rooms) {
+        if (!this.rooms.has(room)) continue;
+
+        for (const id of this.rooms.get(room)) {
+          if (ids.has(id) || except.has(id)) continue;
           const socket = this.nsp.connected.get(id);
-          if (socket) socket.packet(encodedPackets, packetOpts);
+          if (socket) {
+            socket.packet(encodedPackets, packetOpts);
+            ids.add(id);
+          }
         }
       }
-    });
+    } else {
+      for (const [id] of this.sids) {
+        if (except.has(id)) continue;
+        const socket = this.nsp.connected.get(id);
+        if (socket) socket.packet(encodedPackets, packetOpts);
+      }
+    }
   }
 
   /**