Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Please update Starscream pin to 3.0.6 #1105

Closed
grantmike opened this issue Oct 9, 2018 · 0 comments
Closed

Please update Starscream pin to 3.0.6 #1105

grantmike opened this issue Oct 9, 2018 · 0 comments
Labels
enhancement

Comments

@grantmike
Copy link

Starscream recently released
https://github.com/daltoniam/Starscream/releases/tag/3.0.6 which fixes a few crashes that our users are seeing, namely daltoniam/Starscream#524
DmitryPR pushed a commit to DmitryPR/socket.io-client-swift that referenced this issue Nov 28, 2018
Bump Starscream to 3.0.6
3cfd12b 
This solves the issue:
socketio#1105
nuclearace added a commit that referenced this issue Nov 28, 2018
@nuclearace
Merge branch 'development'
e4f63e8 
* development:
  Remove unnecessary function calls.
  Fix build
  Don’t create empty closures when we don’t need them. Fixes #1118.
  Propagate http header callback from websocket back to client.
  clean up emit completion code
  update cartfile too
  update deps: Fix #1105
  update xcode settings
  convert SocketData to serialisable socket representation
  Add a variadic method for emit completion handlers in swift
  no need to capture completion hander in wrapper
  wrap completion handler to run on handleQueue
  add optional write completion handler for emit's
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nuclearace @grantmike