Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error when loading on IE7 #898

Closed
gibson042 opened this issue Nov 8, 2015 · 2 comments
Closed

Error when loading on IE7 #898

gibson042 opened this issue Nov 8, 2015 · 2 comments

Comments

@gibson042
Copy link

Found when running the Sizzle karma suite. IE7 reports "Object doesn't support this property or method" from line 5867.

The offending call (in which json comes from _dereq_('json3')):

 str += json.stringify(obj.data);
gibson042 added a commit to gibson042/socket.io-client that referenced this issue Nov 8, 2015
@gibson042
update JSON3 to 3.3.2
b7325ea 
Fixes socketiogh-898
This was referenced Nov 8, 2015
Closed
Closed
gibson042 added a commit to gibson042/socket.io-parser that referenced this issue Nov 20, 2015
@gibson042
update JSON3 to 3.3.2
009188f 
Also updates zuul so `npm update` completes.

Fixes socketio/socket.io-client#898
@gibson042 gibson042 mentioned this issue Nov 20, 2015
Merged
@gibson042
Copy link
Author

It turns out that this has to be fixed even further upstream. For those playing along at home:

  1. update JSON3 to 3.3.2 socket.io-parser#31
  2. Error when loading on IE7 #898
  3. Error when testing on IE7 karma-runner/karma#1696
  4. Error when testing on oldIE jquery/sizzle#362

@gibson042
Copy link
Author

Whoops; this should be reopened until that code makes it in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@gibson042