Cannot perform %TypedArray%.prototype.set on a detached ArrayBuffer when using with uWebSockets #4281
-
|
Hey Here is the example I used: server.js: const { App } = require("uWebSockets.js");
const { Server } = require("socket.io");
const app = new App();
const io = new Server({ cors: {
origin: "*",
methods: ["GET", "POST", "PUT"]
}});
io.attachApp(app);
io.on("connection", (socket) => {
// ...
});
app.listen(9000, (token) => {
if (!token) {
console.warn("port already in use");
}
});demo.html <!doctype html>
<html>
<head>
<title>Socket.IO uWS</title>
</head>
<script src="node_modules/socket.io/client-dist/socket.io.js"></script>
<script src="https://code.jquery.com/jquery-3.4.1.min.js"></script>
<script>
$(function () {
var socket = io(
'ws://127.0.0.1:9000',
{
// transports: ["websocket"] // ----> it works if you add this
});
socket.onAny((eventName, ...args) => {
console.log("received event: " + eventName);
});
});
</script>
<body>
</body>
</html>Any idea about this issue ? |
Beta Was this translation helpful? Give feedback.
Replies: 6 comments 4 replies
-
|
Hi! I was not able to reproduce the issue with the code you provided. Could it be linked to the Node.js version (v17.0.1)? Could you please try with latest v16 for example? |
Beta Was this translation helpful? Give feedback.
-
|
Hey, I tried with Node version {
"name": "uws",
"version": "1.0.0",
"description": "",
"scripts": {
"start": "node server.js"
},
"author": "",
"license": "ISC",
"dependencies": {
"socket.io": "^4.4.1",
"uWebSockets.js": "github:uNetworking/uWebSockets.js#v20.6.0"
}
}
|
Beta Was this translation helpful? Give feedback.
-
|
@darrachequesne |
Beta Was this translation helpful? Give feedback.
-
|
@darrachequesne You are doing this wrong on this line https://github.com/socketio/engine.io/blob/a463d268ed90064e7863679bda423951de108c36/lib/transports-uws/polling.ts#L158 You are trying to concat Buffer views of arrayBuffers that are already gone. Allocate a buffer with correct size and copy arrayBuffers to it |
Beta Was this translation helpful? Give feedback.
-
|
The example file for onData https://github.com/uNetworking/uWebSockets.js/blob/master/examples/JsonPost.js#L63 is not the best because it concats arrayBuffers on each new chunk, this is a lot of extra copying because concat creates a new copy. Your method of gathering arrayBuffers into an array and then concat is slightly better except Buffer.from() creates a view not a copy, but even if you make copies that is still not efficient because there is 1 copy then final copy, also if 1st chunk is last you are making 2 copies when you need 0 copies. The best method is Buffer.allocUnsafe(size) and copy arrayBuffers to it, this gives 1 total copy per chunk, and if 1st chunk is last you skip that and use the 1st arrayBuffer for zero copies. You get allocated Buffer size from req.getHeader('content-length') then confirm total size matches and is under limit |
Beta Was this translation helpful? Give feedback.
-
|
That makes sense. Could you please open a PR for this? |
Beta Was this translation helpful? Give feedback.
-
|
Added PR here for review socketio/engine.io#642 |
Beta Was this translation helpful? Give feedback.
-
|
@darrachequesne any update on this ? thanks. |
Beta Was this translation helpful? Give feedback.
-
|
I'm looking into it. |
Beta Was this translation helpful? Give feedback.
-
|
This should be fixed by socketio/engine.io@3367440, included in In Safari, the server did receive two chunks during the Socket.IO handshake, the first being empty: |
Beta Was this translation helpful? Give feedback.
This should be fixed by socketio/engine.io@3367440, included in
engine.io@6.1.3.In Safari, the server did receive two chunks during the Socket.IO handshake, the first being empty: