Client-side disconnect gets fired when leaving page in Firefox but not in Chrome #3639
Comments
|
@Tilogorn I could indeed reproduce, thanks a lot for the example. It seems the WebSocket instance emits an |
|
I thought it's more of a timing thing. Like both browsers emit the Not sure if this is fixable by socket.io though... I'm sure you don't want to have code like |
|
Hello, are there any updates on this bug? |
|
This should be fixed by socketio/engine.io-client@ed48b5d, included in |
Since [1], the socket is now closed when receiving the "beforeunload"
event in the browser.
This change was meant to fix a discrepancy between Chrome and Firefox
when the user reloads/closes a browser tab: Firefox would close the
connection (and emit a "disconnect" event, at the Socket.IO level), but
not Chrome (see [2]).
But it also closes the connection when there is another "beforeunload"
handler, for example when the user is prompted "are you sure you want
to leave this page?".
Note: calling "stopImmediatePropagation()" was a possible workaround:
```js
window.addEventListener('beforeunload', (event) => {
event.preventDefault();
event.stopImmediatePropagation();
event.returnValue = 'are you sure you want to leave this page?';
});
```
This commit adds a "closeOnBeforeunload" option, which controls whether
a handler is registered for the "beforeunload" event.
Syntax:
```js
const socket = require('engine.io-client')('ws://localhost', {
closeOnBeforeunload: false // defaults to true
});
```
[1]: ed48b5d
[2]: socketio/socket.io#3639
Related:
- #661
- #658
- socketio/socket.io-client#1451
Reference: https://developer.mozilla.org/en-US/docs/Web/API/Window/beforeunload_event
I want to:
Current behaviour
The
socket.on('disconnect')event on the client-side gets fired, when you leave the page in Firefox. Does not happen in Chrome.I show an error modal when the socket looses its connection because I assume the server went down (not a rare scenario on an embedded device).
Navigating different pages, each with their own
var socket = io();andsocket.on('disconnect')methods leads to unwanted flickering of error modals because the browser assumes for a split second that the server went down until the new page gets loaded.Steps to reproduce (if the current behaviour is a bug)
See my fiddle fork: https://github.com/Tilogorn/socket.io-fiddle
I just added a second page and a link to it.
Open Chrome and navigate to index.html, open the console, check option "persist logs", then click on the link. Nothing special will appear:
Now do the same in Firefox. You will see the
console.logstatement of the disconnect listener.Expected behaviour
Silently leaving the page. Or having a possibility to detect that the user and not the server closed the connection so no need to show an error modal.
reasonistransport closein both ways.Setup
The text was updated successfully, but these errors were encountered: