New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
"Transport not open" after upgrade to v4 #3838
Comments
@RonnieRocket147 are you experiencing this on page reload? I'm seeing this in our app too, repro is something like window.addEventListener('unload', () => {
socket.emit(...);
}); |
@zxlin no we experience it during normal usage. But it might well be related to the same commit you mentioned in socketio/engine.io-client#658. Downgrading to 3.1.3 did resolve our issue. |
I could indeed reproduce, thanks. This seems to be linked to this commit, included in |
In some cases, a "Transport not open" error could be thrown when the transport was silently closed in the onbeforeunload event (added in [1]). To reproduce: ```js window.addEventListener("unload", () => { socket.write("..."); }); ``` [1]: ed48b5d Related: socketio/socket.io#3838
This should be fixed by socketio/engine.io-client@d291a4c, included in |
I noticed also the strange behaviour that |
@RonnieRocket147 yes, that is still the case. Could you please explain what your use case is? And why you think it is a bug? Note: this change was meant to fix the issue here: #3639 |
Let me try to explain my concern. The If Thank you! |
I'm having a similar issue to @RonnieRocket147, ours seems to be triggered by a user clicking on tel protocol links. The user in question also has relatively poor internet, but it only occurs as an actual error when tel protocol links are clicked. |
This could perfectly explain why I noticed random "Transport not open" errors after users where clicking on the page. |
Describe the bug
Yesterday I have upgraded an Angular application which uses socket.io-client to version 4.0.0. The server was also upgraded to 4.0.0. Today our logging recorded multiple "Transport not open" errors on the client side which were never observed before. The (minified) stack trace looks like this:
To Reproduce
Unable to reproduce so far.
Platform:
Additional context
socket.emit()
is only called whensocket.connected
returnstrue
. But somehow during the emit theTransport not open
is thrown.I have downgraded the client to 3.1.3 to see if the error persists and will update this issue tomorrow with the results.
The text was updated successfully, but these errors were encountered: