Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

0.9: Remove process.EventEmitter usage for Node 7.x #2790

Closed
wants to merge 2 commits into from
Closed

0.9: Remove process.EventEmitter usage for Node 7.x #2790

wants to merge 2 commits into from

Conversation

jchv
Copy link

@jchv jchv commented Dec 14, 2016

The kind of change this PR does introduce

  • a bug fix
  • a new feature
  • an update to the documentation
  • a code change that improves performance
  • other

Current behaviour

Socket.IO 0.9.x does not work in Node.JS 7.0 due to the removal of process.EventEmitter. A myriad of existing software depends on Socket.IO 0.9.x, therefore it will either be necessary to update Socket.IO 0.9.x, or fork it. Some existing software still using 0.9.x includes the Yez extension for Google Chrome + corresponding Node.JS application.

New behaviour

This patch changes usages of process.EventEmitter to require('events').

process.EventEmitter has been deprecated and removed from Node.
@darrachequesne
Copy link
Member

Hi! Would you know why the travis build fails?

@jchv
Copy link
Author

jchv commented Dec 17, 2016

Not really sure. My guess would be that the ancient version of Node in this branch is not new enough to install the dependencies anymore. Should I bump it to something newer? 0.12, maybe?

@darrachequesne
Copy link
Member

Did you try with 0.10 or 0.12? It seems the tests are run with nodejs 0.6..

@jchv
Copy link
Author

jchv commented Dec 30, 2016

It's proving difficult to try to finagle things into a working state. Socket.IO depends on Expresso, a library that has been dead since around Socket.IO 0.9's time. I'm also seeing trouble with building Microtime, even if I update the package.json, which seems odd since it switched to node-gyp in 0.3.0.

It's worth noting that the difficulty is limited to testing. The library does function, at least on versions of Node.JS that have the event module.

@thegiantbeast
Copy link

+1 for patching this issue.

@darrachequesne
Copy link
Member

Merged as 9ad1fd2, and released as 0.9.18. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants