Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update dependency socket.io to v2 [security] #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

renovate[bot]
Copy link

@renovate renovate bot commented Oct 25, 2021

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
socket.io (source) ~0.9.13 -> ~2.5.1 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2020-28481

The package socket.io before 2.4.0 are vulnerable to Insecure Defaults due to CORS Misconfiguration. All domains are whitelisted by default.

CVE-2024-38355

Impact

A specially crafted Socket.IO packet can trigger an uncaught exception on the Socket.IO server, thus killing the Node.js process.

node:events:502
    throw err; // Unhandled 'error' event
    ^

Error [ERR_UNHANDLED_ERROR]: Unhandled error. (undefined)
    at new NodeError (node:internal/errors:405:5)
    at Socket.emit (node:events:500:17)
    at /myapp/node_modules/socket.io/lib/socket.js:531:14
    at process.processTicksAndRejections (node:internal/process/task_queues:77:11) {
  code: 'ERR_UNHANDLED_ERROR',
  context: undefined
}

Affected versions

Version range Needs minor update?
4.6.2...latest Nothing to do
3.0.0...4.6.1 Please upgrade to socket.io@4.6.2 (at least)
2.3.0...2.5.0 Please upgrade to socket.io@2.5.1

Patches

This issue is fixed by socketio/socket.io@15af22f, included in socket.io@4.6.2 (released in May 2023).

The fix was backported in the 2.x branch today: socketio/socket.io@d30630b

Workarounds

As a workaround for the affected versions of the socket.io package, you can attach a listener for the "error" event:

io.on("connection", (socket) => {
  socket.on("error", () => {
    // ...
  });
});

For more information

If you have any questions or comments about this advisory:

  • Open a discussion here

Thanks a lot to Paul Taylor for the responsible disclosure.

References


Release Notes

socketio/socket.io (socket.io)

v2.5.1

Compare Source

Bug Fixes
  • add a noop handler for the error event (d30630b)
Links:

v2.5.0

Compare Source

⚠️ WARNING ⚠️

The default value of the maxHttpBufferSize option has been decreased from 100 MB to 1 MB, in order to prevent attacks by denial of service.

Security advisory: GHSA-j4f2-536g-r55m

Bug Fixes
  • fix race condition in dynamic namespaces (05e1278)
  • ignore packet received after disconnection (22d4bdf)
  • only set 'connected' to true after middleware execution (226cc16)
  • prevent the socket from joining a room after disconnection (f223178)
Links:

v2.4.1

Compare Source

Reverts
  • fix(security): do not allow all origins by default (a169050)

v2.4.0

Compare Source

Related blog post: https://socket.io/blog/socket-io-2-4-0/

Features (from Engine.IO)
  • add support for all cookie options (19cc582)
  • disable perMessageDeflate by default (5ad2736)
Bug Fixes
  • security: do not allow all origins by default (f78a575)
  • properly overwrite the query sent in the handshake (d33a619)

⚠️ BREAKING CHANGE ⚠️

Previously, CORS was enabled by default, which meant that a Socket.IO server sent the necessary CORS headers (Access-Control-Allow-xxx) to any domain. This will not be the case anymore, and you now have to explicitly enable it.

Please note that you are not impacted if:

  • you are using Socket.IO v2 and the origins option to restrict the list of allowed domains
  • you are using Socket.IO v3 (disabled by default)

This commit also removes the support for '*' matchers and protocol-less URL:

io.origins('https://example.com:443'); => io.origins(['https://example.com']);
io.origins('localhost:3000');          => io.origins(['http://localhost:3000']);
io.origins('http://localhost:*');      => io.origins(['http://localhost:3000']);
io.origins('*:3000');                  => io.origins(['http://localhost:3000']);

To restore the previous behavior (please use with caution):

io.origins((_, callback) => {
  callback(null, true);
});

See also:

Thanks a lot to @​ni8walk3r for the security report.

Links:

v2.3.0

Compare Source

This release mainly contains a bump of the engine.io and ws packages, but no additional features.

Links:

v2.2.0

Compare Source

Features

  • add cache-control header when serving the client source (#​2907)

Bug fixes

  • throw an error when trying to access the clients of a dynamic namespace (#​3355)
Links

v2.1.1

Compare Source

Features

socket.local.to('room101').emit(/* */);

Bug fixes

(client) fire an error event on middleware failure for non-root namespace (https://github.com/socketio/socket.io-client/pull/1202)

Links:

v2.1.0

Compare Source

Features

// by default, the object is recursively scanned to check whether it contains some binary data
// in the following example, the check is skipped in order to improve performance
socket.binary(false).emit('plain-object', object);

// it also works at the namespace level
io.binary(false).emit('plain-object', object);
  • add support for dynamic namespaces (#​3195)
io.of(/^\/dynamic-\d+$/).on('connect', (socket) => {
  // socket.nsp.name = '/dynamic-101'
});

// client-side
const client = require('socket.io-client')('/dynamic-101');

Bug fixes

  • properly emit 'connect' when using a custom namespace (#​3197)
  • include the protocol in the origins check (#​3198)

Important note ⚠️ from Engine.IO 3.2.0 release

There are two non-breaking changes that are somehow quite important:

  • ws was reverted as the default wsEngine (https://github.com/socketio/engine.io/pull/550), as there was several blocking issues with uws. You can still use uws by running npm install uws --save in your project and using the wsEngine option:
var engine = require('engine.io');
var server = engine.listen(3000, {
  wsEngine: 'uws'
});
Links:

v2.0.4

Compare Source

Bug fixes

  • do not throw when receiving an unhandled error packet (#​3038)
  • reset rooms object before broadcasting from namespace (#​3039)
Links:

v2.0.3

Compare Source

Bug fixes

  • reset rooms object before broadcasting (#​2970)
  • fix middleware initialization (#​2969)
Links:

v2.0.2

Compare Source

Bug fixes

  • fix timing issues with middleware (#​2948)
Links:

v2.0.1

Compare Source

Bug fixes

- update path of client file (#​2934)

Links:

v2.0.0

Compare Source

This major release brings several performance improvements:

  • uws is now the default Websocket engine. It should bring significant improvement in performance (particularly in terms of memory consumption) (https://github.com/socketio/engine.io/releases/tag/2.0.0)

  • the Engine.IO and Socket.IO handshake packets were merged, reducing the number of roundtrips necessary to establish a connection. (#​2833)

  • it is now possible to provide a custom parser according to the needs of your application (#​2829). Please take a look at the example for more information.

Please note that this release is not backward-compatible, due to:

Please also note that if you are using a self-signed certificate, rejectUnauthorized now defaults to true (https://github.com/socketio/engine.io-client/pull/558).

Finally, the API documentation is now in the repository (here), and the content of the website here. Do not hesitate if you see something wrong or missing!

The full list of changes:

Besides, we are proud to announce that Socket.IO is now a part of open collective: https://opencollective.com/socketio. More on that later.

v1.7.4

Compare Source

  • [chore] Bump engine.io to version 1.8.4

v1.7.3

Compare Source

  • [chore] Bump engine.io-client to version 1.8.3

v1.7.2

Compare Source

  • [chore] Bump engine.io to version 1.8.2 (#​2782)
  • [fix] Fixes socket.use error packet (#​2772)

v1.7.1

Compare Source

(following socket.io-client update)

v1.7.0

Compare Source

  • [docs] Comment connected socket availability for adapters (#​2081)
  • [docs] Fixed grammar issues in the README.md (#​2159)
  • [feature] serve sourcemap for socket.io-client (#​2482)
  • [feature] Add a local flag (#​2628)
  • [chore] Bump engine.io to version 1.8.1 (#​2765)
  • [chore] Update client location and serve minified file (#​2766)

v1.6.0

Compare Source

  • [fix] Make ETag header comply with standard. (#​2603)
  • [feature] Loading client script on demand. (#​2567)
  • [test] Fix leaking clientSocket (#​2721)
  • [feature] Add support for all event emitter methods (#​2601)
  • [chore] Update year to 2016 (#​2456)
  • [feature] Add support for socket middleware (#​2306)
  • [feature] add support for Server#close(callback) (#​2748)
  • [fix] Don't drop query variables on handshake (#​2745)
  • [example] Add disconnection/reconnection logs to the chat example (#​2675)
  • [perf] Minor code optimizations (#​2219)
  • [chore] Bump debug to version 2.3.3 (#​2754)
  • [chore] Bump engine.io to version 1.8.0 (#​2755)
  • [chore] Bump socket.io-adapter to version 0.5.0 (#​2756)

v1.5.1

Compare Source

  • [fix] Avoid swallowing exceptions thrown by user event handlers (#​2682)
  • [test] Use client function to unify client in test script (#​2731)
  • [docs] Add link to LICENSE (#​2221)
  • [docs] Fix JSDoc of optional parameters (#​2465)
  • [docs] Fix typo (#​2724)
  • [docs] Link readme npm package badge to npm registry page (#​2612)
  • [docs] Minor fixes (#​2526)
  • [chore] Bump socket.io-parser to 2.3.0 (#​2730)
  • [chore] Add Github issue and PR templates (#​2733)
  • [chore] Bump engine.io to 1.7.2 (#​2729)
  • [chore] Bump socket.io-parser to 2.3.1 (#​2734)

v1.5.0

Compare Source

  • [feature] stop append /# before id when no namespace (#​2509)
  • [feature] Add a 'disconnecting' event to access to socket.rooms upon disconnection (#​2332)
  • [fix] Fix query string management (#​2422)
  • [fix] add quote to exec paths, prevent error when spaces in path (#​2508)
  • [docs] Prevent mixup for new programmers (#​2599)
  • [example] Fix chat display in Firefox (#​2477)
  • [chore] Add gulp & babel in the build process (#​2471)
  • [chore] Bump engine.io to 1.7.0 (#​2707)
  • [chore] Remove unused zuul-ngrok dependency (#​2708)
  • [chore] Point towards current master of socket.io-client (#​2710)
  • [chore] Restrict files included in npm package (#​2709)
  • [chore] Link build badge to master branch (#​2549)

v1.4.8

Compare Source

v1.4.7

Compare Source

v1.4.6

Compare Source

v1.4.5

Compare Source

v1.4.4

Compare Source

v1.4.3

Compare Source

v1.4.2

Compare Source

v1.4.1

Compare Source

v1.4.0

Compare Source

v1.3.7

Compare Source

v1.3.6

Compare Source

v1.3.5

Compare Source

v1.3.4

Compare Source

v1.3.3

Compare Source

v1.3.2

Compare Source

v1.3.1

Compare Source

v1.3.0

Compare Source

v1.2.1

Compare Source

v1.2.0

Compare Source

v1.1.0

Compare Source

v1.0.6

Compare Source

v1.0.5

Compare Source

v1.0.4

Compare Source

v1.0.3

Compare Source

v1.0.2

Compare Source

v1.0.1

Compare Source

v1.0.0

Compare Source

v0.9.19

Compare Source

  • Properly require EventEmitter

v0.9.18

Compare Source

v0.9.15

Compare Source

v0.9.14

Compare Source


Configuration

📅 Schedule: Branch creation - "" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 3719344 to 0662583 Compare October 25, 2021 22:04
@renovate renovate bot changed the title Pin dependency socket.io to v0.9.19 [SECURITY] Update dependency socket.io to v2 [SECURITY] Oct 25, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 0662583 to 2fa03a8 Compare October 25, 2021 22:09
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to v4 [SECURITY] Oct 25, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 2fa03a8 to c57c6c2 Compare October 25, 2021 22:13
@renovate renovate bot changed the title Update dependency socket.io to v4 [SECURITY] Update dependency socket.io to ~0.9.19 [SECURITY] Oct 25, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from c57c6c2 to 149ad59 Compare October 26, 2021 00:49
@renovate renovate bot changed the title Update dependency socket.io to ~0.9.19 [SECURITY] Update dependency socket.io to v2 [SECURITY] Oct 26, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 149ad59 to 19740df Compare October 28, 2021 15:33
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to ~0.9.19 [SECURITY] Oct 28, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 19740df to 07003d0 Compare October 28, 2021 17:22
@renovate renovate bot changed the title Update dependency socket.io to ~0.9.19 [SECURITY] Update dependency socket.io to v2 [SECURITY] Oct 28, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 07003d0 to 6ccf6b9 Compare October 29, 2021 03:51
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to ~0.9.19 [SECURITY] Oct 29, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 6ccf6b9 to ddd7880 Compare October 29, 2021 05:49
@renovate renovate bot changed the title Update dependency socket.io to ~0.9.19 [SECURITY] Update dependency socket.io to v2 [SECURITY] Oct 29, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from ddd7880 to 0c80785 Compare November 4, 2021 12:01
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to ~0.9.19 [SECURITY] Nov 4, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 0c80785 to b36d42e Compare November 4, 2021 13:19
@renovate renovate bot changed the title Update dependency socket.io to ~0.9.19 [SECURITY] Update dependency socket.io to v2 [SECURITY] Nov 4, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from b36d42e to 92972d5 Compare November 4, 2021 17:12
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to ~0.9.19 [SECURITY] Nov 4, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 92972d5 to 326b4e2 Compare November 4, 2021 19:45
@renovate renovate bot changed the title Update dependency socket.io to ~0.9.19 [SECURITY] Update dependency socket.io to v2 [SECURITY] Nov 4, 2021
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to ~0.9.19 [SECURITY] Nov 5, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch 2 times, most recently from 374255d to 1c79c6e Compare November 5, 2021 14:35
@renovate renovate bot changed the title Update dependency socket.io to ~0.9.19 [SECURITY] Update dependency socket.io to v2 [SECURITY] Nov 5, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 1c79c6e to 9eb1217 Compare November 8, 2021 13:17
@renovate renovate bot changed the title Update dependency socket.io to v2 [SECURITY] Update dependency socket.io to ~0.9.19 [SECURITY] Nov 8, 2021
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 544dcc0 to 1536bd6 Compare June 6, 2024 02:51
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v2 [security] fix(deps): update dependency socket.io to v4 [security] Jun 6, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 1536bd6 to dcf26dc Compare June 7, 2024 04:43
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v4 [security] fix(deps): update dependency socket.io to v2 [security] Jun 7, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from dcf26dc to b78dbbd Compare June 19, 2024 23:42
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from b78dbbd to c3b84c9 Compare June 28, 2024 02:20
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v2 [security] fix(deps): update dependency socket.io to v4 [security] Jun 28, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from c3b84c9 to 21f6fca Compare June 29, 2024 08:21
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v4 [security] fix(deps): update dependency socket.io to v2 [security] Jun 29, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 21f6fca to 74c3a7f Compare July 14, 2024 23:24
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v2 [security] fix(deps): update dependency socket.io to v4 [security] Jul 14, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 74c3a7f to 365e191 Compare July 15, 2024 05:36
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v4 [security] fix(deps): update dependency socket.io to v2 [security] Jul 15, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 365e191 to b7c1570 Compare July 21, 2024 17:58
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v2 [security] fix(deps): update dependency socket.io to v4 [security] Jul 21, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from b7c1570 to dbe070b Compare July 24, 2024 02:43
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v4 [security] fix(deps): update dependency socket.io to v2 [security] Jul 24, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from dbe070b to 6941add Compare July 29, 2024 11:39
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v2 [security] fix(deps): update dependency socket.io to v4 [security] Jul 29, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 6941add to 182c0e4 Compare July 31, 2024 08:52
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v4 [security] fix(deps): update dependency socket.io to v2 [security] Jul 31, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 182c0e4 to d1e8bb5 Compare October 10, 2024 17:54
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v2 [security] fix(deps): update dependency socket.io to v4 [security] Oct 10, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from d1e8bb5 to bbab1dd Compare October 11, 2024 05:57
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v4 [security] fix(deps): update dependency socket.io to v2 [security] Oct 11, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from bbab1dd to 55cfdac Compare October 30, 2024 02:52
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v2 [security] fix(deps): update dependency socket.io to v4 [security] Oct 30, 2024
@renovate renovate bot force-pushed the renovate/npm-socket.io-vulnerability branch from 55cfdac to 652a5c3 Compare November 1, 2024 05:45
@renovate renovate bot changed the title fix(deps): update dependency socket.io to v4 [security] fix(deps): update dependency socket.io to v2 [security] Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants