-
Notifications
You must be signed in to change notification settings - Fork 10.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Logger #563
Logger #563
Conversation
logger.level = this.get('log level') || -1; | ||
logger.colors = this.get('log colors'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we should use isatty()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could use isatty to set the initial value of log colors
. This way users can still configure it, but it defaults to the most optimal one.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sounds good to me
For me this still shows
Is it possible to also disable this? I tried a little hacking, but without luck? |
|
@3rd-Eden Bingo :) |
You can now disable logging again using
io.disable('log')
Also added support for killing the color output using
io.disable('log colors')
<-- painful in productionAdded tests against it and added another test against static because etags can kill far future headers.