Stop children even if the current task is deferring stop. #312
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ioquatix
force-pushed
the
defer_stop-children
branch
from
ca20a12
to
2f2deef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Defer stop does not mean "don't stop". It means there is some code which should ignore stop for a little while and the stop, kind of like an asynchronous ensure block. Therefore, I don't think we should prevent it from propagating to child tasks.
In particular, if you have a server task that is handling one or more child tasks (responses), those tasks should be stopped.
The alternative is to make
defer_stopparameteric, but I'm trying to avoid increasing the complexity of this interface.Types of Changes
Contribution