SSL Socket test sometimes loops forever #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lect this in the test
tarcieri
added a commit
that referenced
this pull request
May 6, 2012
SSL Socket test sometimes loops forever
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
On my OS X Mac, the SSL socket test will sometimes enter an infinite loop trying to create an unwritable SSL socket. The reason is that Kernel#select will report the socket writable event though write_nonblock throws an exception when any data is written. I've restructured the logic to trap this condition with a "pending" block (though I cannot confirm that the test passes on other machines).