Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove console log statement on cookie secret in engine.io #559

Closed
paulbjensen opened this issue Jun 7, 2015 · 2 comments
Closed

Remove console log statement on cookie secret in engine.io #559

paulbjensen opened this issue Jun 7, 2015 · 2 comments
Milestone
0.4.3

Comments

@paulbjensen
Copy link
Contributor

I see a line like "secret in engine.io feK4li1aek8koe7JeiC3shai7ahy7uduch5ahY7n" when running the latest SS. It seems like a console logging statement that has been left somewhere in the codebase. I will find it and strip it out.
@thepian thepian added this to the 0.4.3 milestone Jun 7, 2015
@kulicuu
Copy link

kulicuu commented Jun 7, 2015

etstream/lib $ grep -R "secret in engine.io" websocket/transports/engineio/index.js: c('secret in engine.io', secret);

my bad. I would need to pull latest and some associated tasks before PR for it.

@kulicuu
Copy link

kulicuu commented Jun 8, 2015

fixed at
495229c

@kulicuu kulicuu closed this as completed Jun 8, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.4.3
Development

No branches or pull requests
3 participants
@paulbjensen @thepian @kulicuu