Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/update dependencies #574

Merged
merged 7 commits into from
Sep 16, 2015
Merged

Feature/update dependencies #574

merged 7 commits into from
Sep 16, 2015

Conversation

thepian
Copy link
Member

@thepian thepian commented Aug 29, 2015

and pack improvements/fixes


ss.tasks.start(['pack-if-needed'],function() {
ss.tasks.start(['pack-if-needed'],function(err) { //TODO pack tasks passes error

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'err' is defined but never used.

console.log('Connection back up :-)');
});

ss.server.on('ready', function(){

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'ss' is not defined.

some rewriting needed. with mock expectations for toMinifiedJS perhaps
thepian added a commit that referenced this pull request Sep 16, 2015
@thepian thepian merged commit ff510dd into master Sep 16, 2015
@thepian thepian deleted the feature/update-dependencies branch September 16, 2015 22:14
@arxpoetica
Copy link
Member

👍 👍 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants