-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve 'RuntimeWorker' implementation #776
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwerle
added
enhancement
New feature or request
javascript
An issue, discussion, or task related to the runtime javascript
api
An issue, task, or discussion related to public runtime APIs
runtime
An issue, task, or discussion related to the runtime core
labels
Nov 20, 2023
- unique ID for every worker - dispatch "post" data request in worker thread - ensure 'globalThis.__args' exists as a primordial
… in 'socket:ipc' now
…its in 'socket.ini'
jwerle
force-pushed
the
improve-workers
branch
from
November 20, 2023 14:04
fab645b
to
90d726c
Compare
heapwolf
approved these changes
Nov 20, 2023
chicoxyzzy
approved these changes
Nov 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api
An issue, task, or discussion related to public runtime APIs
enhancement
New feature or request
javascript
An issue, discussion, or task related to the runtime javascript
runtime
An issue, task, or discussion related to the runtime core
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the
Worker
implementation and allows for workers to request dispatched "post" data in their own threads. This improves the experience of creating UDP sockets, binding, and receiving data entirely in the worker thread.