Smart 'dgram.Socket' reuse #777
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jwerle
added
enhancement
heapwolf
approved these changes
Nov 20, 2023
chicoxyzzy
approved these changes
Nov 20, 2023
jwerle
force-pushed
the
smart-socket-reuse
branch
from
e8e4ffb
to
cf7b7d3
Compare
|
Looks great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR introduces a smart mechanism for reusing underlying socket handles by deriving the underlying
idfrom thehostandportwhenport !== 0andreuseAddr === truesuch that an already knownidwas not given tocreateSocket(). The implementation uses themurmur3non cryptographic hashing algorithm based on https://github.com/jwerle/murmurhash.c. It uses the current window index as theseedvalue and the concatenatedhost + porttuple as an input value. This PR depends on #776