Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove narrow exports specifier #858

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Remove narrow exports specifier #858

merged 1 commit into from
Dec 21, 2023

Conversation

heapwolf
Copy link
Member

This causes problems with things like loaders...

> /usr/bin/node --experimental-loader @socketsupply/socket/node-esm-loader.js introducer.js

(node:864627) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
node:internal/errors:490
    ErrorCaptureStackTrace(err);
    ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './node-esm-loader.js' is not defined by "exports" in /opt/streamrelay/node_modules/@socketsupply/socket/package.json imported from /opt/streamrelay/
    at new NodeError (node:internal/errors:399:5)
    at exportsNotFound (node:internal/modules/esm/resolve:266:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:602:9)
    at packageResolve (node:internal/modules/esm/resolve:777:14)
    at moduleResolve (node:internal/modules/esm/resolve:843:20)
    at ESMLoader.defaultResolve (node:internal/modules/esm/resolve:1058:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:323:32)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:172:38)
    at ESMLoader.import (node:internal/modules/esm/loader:276:22)
    at initializeLoader (node:internal/process/esm_loader:50:63) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}

This causes problems with things like loaders...

```
> /usr/bin/node --experimental-loader @socketsupply/socket/node-esm-loader.js introducer.js

(node:864627) ExperimentalWarning: Custom ESM Loaders is an experimental feature and might change at any time
(Use `node --trace-warnings ...` to show where the warning was created)
node:internal/errors:490
    ErrorCaptureStackTrace(err);
    ^

Error [ERR_PACKAGE_PATH_NOT_EXPORTED]: Package subpath './node-esm-loader.js' is not defined by "exports" in /opt/streamrelay/node_modules/@socketsupply/socket/package.json imported from /opt/streamrelay/
    at new NodeError (node:internal/errors:399:5)
    at exportsNotFound (node:internal/modules/esm/resolve:266:10)
    at packageExportsResolve (node:internal/modules/esm/resolve:602:9)
    at packageResolve (node:internal/modules/esm/resolve:777:14)
    at moduleResolve (node:internal/modules/esm/resolve:843:20)
    at ESMLoader.defaultResolve (node:internal/modules/esm/resolve:1058:11)
    at ESMLoader.resolve (node:internal/modules/esm/loader:323:32)
    at ESMLoader.getModuleJob (node:internal/modules/esm/loader:172:38)
    at ESMLoader.import (node:internal/modules/esm/loader:276:22)
    at initializeLoader (node:internal/process/esm_loader:50:63) {
  code: 'ERR_PACKAGE_PATH_NOT_EXPORTED'
}
```
@@ -5,10 +5,6 @@
"type": "module",
"main": "index.js",
"types": "index.d.ts",
"exports": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we keep this as:

  "exports": {
    "types": "./index.d.ts"
  },

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

im not sure if there is a way, specifying the exports field is the problem because iirc it makes it exclusive.

@jwerle jwerle added bug Something isn't working npm An issue, task, discussion, or pull request related to the NPM modules labels Dec 21, 2023
@heapwolf heapwolf merged commit 0d29340 into master Dec 21, 2023
6 of 10 checks passed
@heapwolf heapwolf deleted the heapwolf-patch-1 branch December 21, 2023 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working npm An issue, task, discussion, or pull request related to the NPM modules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants