Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix class names #118

Closed
wants to merge 2 commits into from
Closed

Fix class names #118

wants to merge 2 commits into from

Conversation

nichoth
Copy link
Contributor

@nichoth nichoth commented Oct 19, 2023

Fix #117

Change parsing so that class names are added correctly, and add a test for this.

@nichoth nichoth closed this Oct 20, 2023
@nichoth
Copy link
Contributor Author

nichoth commented Oct 20, 2023 •
edited

Better to use quotes in the instance method, eg class="${abc}", not class=${abc}.

@nichoth nichoth mentioned this pull request Oct 20, 2023
Closed
@bcomnes
Copy link
Contributor

bcomnes commented Oct 20, 2023

I think syntax highlighters are also more forgiving when you ensure quotes around your attribute values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Multiple class names are not added correctly
2 participants
@nichoth @bcomnes