Make ESM the default format #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
heapwolf
approved these changes
Aug 26, 2022
|
@chicoxyzzy can you rebase and merge? |
chicoxyzzy
force-pushed
the
esm
branch
2 times, most recently
from
8cb1b5e
to
eeaff1c
Compare
|
@heapwolf this PR removes minified version. Is it ok or we still want to have it? I think I will bring it back to be able to use Tonic via unpkg.com, etc |
|
should this be a major version or minor? technically it has breaking changes |
I would say major version. Thank you for keeping the minified files too. |
|
End of an era, no more commonJS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also:
isTonicComponentgetter to the Tonic classrequire('package').versionin the runtime (which also breaks old esm version)