Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minimum support for hybi13 #22

Merged
merged 1 commit into from
Oct 18, 2011
Merged

Minimum support for hybi13 #22

merged 1 commit into from
Oct 18, 2011

Conversation

stephank
Copy link
Contributor

Chrome Canary builds are now using websocket protocol version 13, from draft-ietf-hybi-thewebsocketprotocol-17. This commit basically matches the work done in the related WebKit commit and pywebsocket commit.

majek added a commit that referenced this pull request Oct 18, 2011
Minimum support for hybi13
@majek majek merged commit 653a38d into sockjs:master Oct 18, 2011
@majek
Copy link
Member

majek commented Oct 18, 2011

Applied, Thanks. We should also make sure that the handling of Origin header is correct.

@stephank
Copy link
Contributor Author

I was wondering about that. I'm no expert, but...

  • draft-hixie-thewebsocketprotocol-76 has a request header named Origin.
  • draft-ietf-hybi-thewebsocketprotocol-10 has a request header named Sec-WebSocket-Origin
  • draft-ietf-hybi-thewebsocketprotocol-17 has a request header named Origin

So it looks like we're only wrong for draft hybi 10, but I don't know about the intermediate drafts, and if they're in use at all.

On top of that, draft hixie 76 had a response header Sec-WebSocket-Origin as well, which seems to have be removed completely in the other two drafts.

@majek
Copy link
Member

majek commented Oct 25, 2011

Is hybi-17 in chrome 15?

@stephank
Copy link
Contributor Author

Nope. Current Canary will be Chrome 16.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants