Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

/echo should not be required to have JSESSIONID set #46

Closed
majek opened this issue Mar 28, 2012 · 0 comments
Closed

/echo should not be required to have JSESSIONID set #46

majek opened this issue Mar 28, 2012 · 0 comments

Comments

@majek
Copy link
Member

majek commented Mar 28, 2012

Currently /echo service is required to have JSESSIONID option set. This is wrong and makes the deployment of QUnit tests tedious.

We should leave the JSESSIONID requirements alone from all the service used by QUnit tests and introduce another /cookie_needed_echo service especially to check cookies. This will be in similar fashion to /disabled_websocket_echo service.
majek added a commit that referenced this issue Mar 28, 2012
@majek
#46 - don't check for JSESSIONID cookie except in /cookie_needed_echo…
f31a4b2 
… resource
majek added a commit that referenced this issue Mar 28, 2012
@majek
#46 - Don't require /echo to have cookie_needed set, but do require t…
0572bb5 
…hat from /cookie_needed_echo
majek added a commit to sockjs/sockjs-erlang that referenced this issue Mar 28, 2012
@majek
sockjs/sockjs-protocol#46 - introduce new /cookie_needed_echo service
758ad99
majek added a commit to sockjs/sockjs-node that referenced this issue Mar 28, 2012
@majek
sockjs/sockjs-protocol#46 - introduce new /cookie_needed_echo service
6a979cf
majek added a commit to sockjs/sockjs-node that referenced this issue Mar 28, 2012
@majek
sockjs/sockjs-protocol#46 - Disable JSESSIONID by default (!)
64155b3
@majek majek closed this as completed Apr 2, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@majek