Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove reference to unused collocation groups #593

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Remove reference to unused collocation groups #593

wants to merge 2 commits into from

Conversation

zachlefevre
Copy link
Contributor

No description provided.

@zachlefevre
Copy link
Contributor Author

According to rjmac the collocation group does not need to exist here. It's simply put here because we reuse the same config as DC.

rlvoyer
rlvoyer approved these changes Aug 9, 2023
View reviewed changes
Copy link
Contributor

@rlvoyer rlvoyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. I assume you verified that the config object in Scala has no reference to this parameter?

@zachlefevre
Copy link
Contributor Author

@rlvoyer there exists another PR which makes the param optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rlvoyer rlvoyer rlvoyer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zachlefevre @rlvoyer