Add namespace and test #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Awesome stuff. You probably figured out somewhere along the way that PHP is not my everyday language. Thanks again for your help. If you ever catch me at an event, track me down. I owe you a beer or three! 🍻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is much more extensive as things have been moved around for
PSR-4autoloading which is why I wanted adevelopbranch and to have the current implementation tagged.I've renamed the class to
socrata\soda\Clientto better match the other libraries. Also, I did have problems testing thePOSTandPUTactions, so the test is currently very 'happy-path'. Any suggestions for making it more robust are welcome.Lastly, this should lay the foundation for extending the library with more robust
SoSQLsupport.While Austin's dangerous dogs are certainly more exciting, the Medicare footnotes are a smaller and simpler data set for demonstration/testing.