Add trailing slash back in

[scottmmjackson]

There's a situation where if the server behind the proxy does the following, you can end up in an infinite redirect:

-> GET /hello
-> -> GET /hello
<- 307 TEMPORARY REDIRECT
<- Location: /hello/
-> GET /hello/
-> -> GET /hello
<- 307 TEMPORARY REDIRECT
<- Location: /hello/

etc.

Rather than try to go too far outside of your design, I altered the combinePaths helper to make a quick check to see if there was a trailing slash in the original request, and if so- to add it back.

The unit tests seem to be failing on Node 6, so I'm not sure what to do about that. Manual tests pass.

[socsieng]

Codebase is really old... given the chance, I'd do things differently. I'm in the process of updating node versions, using yarn, and massaging the tests to work with your new scenarios.

[scottmmjackson]

Cool! Let me know if you'd like some extra eyes/hands. It's working great for my use case right now!

[socsieng]

So the reason for the failing test is related to when the last argument is /.

Updating the condition to read as below does the trick:

if (last !== '/' && last.slice(-1) === '/') {
    path += '/';
}

Do you mind rebasing off master and applying the suggested change?

[socsieng]

Appreciate the contribution by they way.

[scottmmjackson]

I added a couple of test cases drawn to that slash issue. I had to disable one of the FS tests as it was failing on Ubuntu. I also decided to give this awful optimization a shot.

Let me know your thoughts.

[socsieng]

Thanks for this. I've fixed up the failing test and published to npm as version 0.2.6.