Merge pull request #175 from xxwjj/govetcheck

Fixed go vet error
sodafoundation · Dec 12, 2017 · 8d3d644 · 8d3d644
2 parents 337376b + dea49f1
commit 8d3d644
Show file tree

Hide file tree

Showing 4 changed files with 5 additions and 5 deletions.
diff --git a/cmd/osdsctl/main.go b/cmd/osdsctl/main.go
@@ -38,7 +38,7 @@ func main() {
 	// Open OpenSDS CLI service log file
 	f, err := os.OpenFile(logDir+"/osdsctl.log", os.O_RDWR|os.O_CREATE|os.O_APPEND, 0666)
 	if err != nil {
-		fmt.Errorf("Error opening file:%v", err)
+		fmt.Printf("Error opening file:%v", err)
 		os.Exit(1)
 	}
 	defer f.Close()

diff --git a/contrib/drivers/huawei/dorado/dorado.go b/contrib/drivers/huawei/dorado/dorado.go
@@ -129,7 +129,7 @@ func (d *Driver) PullVolume(volID string) (*model.VolumeSpec, error) {
 func (d *Driver) DeleteVolume(opt *pb.DeleteVolumeOpts) error {
 	err := d.client.DeleteVolume(opt.Id)
 	if err != nil {
-		log.Errorf("Delete volume failed, volume id =%s , Error:%s", opt.GetId())
+		log.Errorf("Delete volume failed, volume id =%s , Error:%s", opt.GetId(), err)
 	}
 	log.Info("Remove volume success, volume id =", opt.GetId())
 	return nil

diff --git a/contrib/drivers/utils/config/config.go b/contrib/drivers/utils/config/config.go
@@ -36,7 +36,7 @@ func Parse(conf interface{}, p string) (interface{}, error) {
 		return nil, err
 	}
 	if err = yaml.Unmarshal(confYaml, conf); err != nil {
-		log.Fatal("Parse error: %v", err)
+		log.Fatalf("Parse error: %v", err)
 		return nil, err
 	}
 	return conf, nil

diff --git a/pkg/db/db.go b/pkg/db/db.go
@@ -37,7 +37,7 @@ func Init(db *Database) {
 	switch db.Driver {
 	case "mysql":
 		// C = mysql.Init(db.Driver, db.Crendential)
-		fmt.Errorf("mysql is not implemented right now!")
+		fmt.Printf("mysql is not implemented right now!")
 		return
 	case "etcd":
 		C = etcd.NewClient(strings.Split(db.Endpoint, ","))
@@ -46,7 +46,7 @@ func Init(db *Database) {
 		C = fakedb.NewFakeDbClient()
 		return
 	default:
-		fmt.Errorf("Can't find database driver %s!\n", db.Driver)
+		fmt.Printf("Can't find database driver %s!\n", db.Driver)
 	}
 }