Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Special characters in file share name is not supported by backend #1003

Open
Shruthi-1MN opened this issue Sep 4, 2019 · 1 comment
Open
Assignees
Labels
bug Something isn't working

Comments

@Shruthi-1MN
Copy link
Contributor

Is this a BUG REPORT or FEATURE REQUEST?:
Special characters in file share name is not supported in backend but db entry is creating and getting 202 for creating request

Uncomment only one, leave it on its own line:

/kind bug
/kind feature

What happened:
Integration test case ran

It("TC_FS_IT_04: Create file share name having special characters ", func() {
			var jsonStr2 = map[string]interface{}{"name": "#FileShare Code!$!test", "description": "This is just for testxxx", "size": 2, "profileId": "df40af1a-17b5-48e5-899f-fa098b0bd5da"}
			url := "http://127.0.0.1:50040/v1beta/e93b4c0934da416eb9c8d120c5d04d96/file/shares"
			methodName := "POST"
			resp, _ := utils.ConnectToHTTP(methodName, url, jsonStr2)
			Expect(resp.StatusCode).Should(Equal(202))
		})

output is creating db entry

{"id":"d0623fea-c365-4156-a680-696ce8eae262","createdAt":"2019-09-04T11:44:02","updatedAt":"2019-09-04T11:44:02","tenantId":"e93b4c0934da416eb9c8d120c5d04d96","name":"#FileShare Code!$!test","description":"This is just for testxxx","size":2,"availabilityZone":"default","status":"creating","profileId":"df40af1a-17b5-48e5-899f-fa098b0bd5da"}•Resp is ... :&{202 Accepted 202 HTTP/1.1 1 1 map[Content-Length:[326] Content-Type:[application/json; charset=utf-8] Date:[Wed, 04 Sep 2019 06:14:02 GMT]] 0xc0002141c0 326 [] false false map[] 0xc0001c6f00 <nil>}response Status: 202 Accepted

But backend is not supporting - osdsdock.log

E0904 10:41:19.754496   26001 dock.go:537] when create file share in dock module:exit status 1
E0904 10:41:19.777910   26001 exec.go:41] Execute command failed
info:
  Logical volume name "#FileShare Code!$! test" is invalid.
  Run `lvcreate --help' for more information.

error: exit status 3

What you expected to happen:
It is should throw error as special characters file share name is not allowed

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:

Environment:

  • Hotpot(release/branch) version:
  • OS (e.g. from /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:
@skdwriting skdwriting added this to the Daito SODA v1.0 milestone Oct 25, 2019
@wisererik wisererik added the bug Something isn't working label Oct 25, 2019
@Shruthi-1MN
Copy link
Contributor Author

Following the standards of file name standards in Linux/Unix this issue has been raised ref link https://www.cyberciti.biz/faq/linuxunix-rules-for-naming-file-and-directory-names/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants