This repository has been archived by the owner on Sep 4, 2022. It is now read-only.
Add convenience functions for pwhash() and derive_key() #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
manuels
force-pushed
the
patch-1
branch
2 times, most recently
from
753fd19
to
2920427
Compare
Pull Request Test Coverage Report for Build 923
💛 - Coveralls |
kpp
reviewed
Jan 22, 2019
| /// `derive_key_interactive()` is a shortcut function for `derive_key()` with | ||
| /// interactive limits (i.e. using `derive_key()` with `OPSLIMIT_INTERACTIVE` | ||
| /// and `MEMLIMIT_INTERACTIVE`) | ||
| pub fn derive_key_interactive<'a>( |
There was a problem hiding this comment.
Do you need that <'a>? Give rustc a try
There was a problem hiding this comment.
Yes, the compiler will fail if 'a is missing.
manuels
force-pushed
the
patch-1
branch
3 times, most recently
from
5c0af94
to
733f0f4
Compare
The limit arguments in pwhash() and derive_key() with its two parameters is a bit "loud" with its two (for most users) constant parameters. This adds two convenience functions for both.
|
bors: try |
tryBuild failed |
|
bors: try |
|
🔒 Permission denied Existing reviewers: click here to make manuels a reviewer |
Dylan-DPC-zz
approved these changes
Apr 10, 2019
|
bors: r+ |
bors bot
added a commit
that referenced
this pull request
Apr 10, 2019
309: Add convenience functions for pwhash() and derive_key() r=Dylan-DPC a=manuels The limit arguments in pwhash() and derive_key() with its two parameters is a bit "loud" with its two (for most users) constant parameters. This adds two convenience functions for both. Co-authored-by: manuels <manuel.schoelling@gmx.de> Co-authored-by: Dylan DPC <dylan.dpc@gmail.com> Co-authored-by: Manuel Schölling <manuel.schoelling@gmx.de>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The limit arguments in pwhash() and derive_key() with its two parameters is a bit "loud" with its two (for most users) constant parameters. This adds two convenience functions for both.