Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patches to allow MMseqs2 to build with gcc13 #714

Merged
merged 4 commits into from
Jun 9, 2023
Merged

Patches to allow MMseqs2 to build with gcc13 #714

merged 4 commits into from
Jun 9, 2023

Conversation

A-N-Other
Copy link
Contributor

Due to changes in the way it handles includes, MMseqs2 wasn't building with gcc13. These 4 files required patching to make them behave ...

@milot-mirdita
Copy link
Member

Thank you, what platform are you compiling on? My homebrew gcc 13 doesn't complain.

@A-N-Other
Copy link
Contributor Author

Building on linux-rocky8-x86_64. I've just been patching it for Spack, so figured I'd push it across. These changes are as per https://gcc.gnu.org/gcc-13/porting_to.html

@milot-mirdita milot-mirdita merged commit 3e43617 into soedinglab:master Jun 9, 2023
2 of 15 checks passed
@milot-mirdita
Copy link
Member

I guess I am using libc++ with the Homebrew GCC, so that would make sense. Thank you :)

@A-N-Other A-N-Other mentioned this pull request Jun 9, 2023
Merged
@milot-mirdita milot-mirdita mentioned this pull request Aug 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@A-N-Other @milot-mirdita