src/a3m_compress.h: fix build failure with gcc 13 #357
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following header changes in gcc 13, hh-suite fails to build with the following errors: In file included from /<<PKGBUILDDIR>>/src/a3m_compress.cpp:8: /<<PKGBUILDDIR>>/src/a3m_compress.h:37:37: error: ‘uint16_t’ has not been declared 37 | void writeU16(std::ostream& file, uint16_t); | ^~~~~~~~ /<<PKGBUILDDIR>>/src/a3m_compress.h:38:28: error: ‘uint16_t’ has not been declared 38 | void readU16(char** ptr, uint16_t &result); | ^~~~~~~~ […] Including cstdint in the affected file allows the build to go through. This issue has initially been reported in [Debian bug #1037689]. [Debian bug #1037689]: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1037689 Signed-off-by: Étienne Mollier <emollier@debian.org>
ghost
pushed a commit
to NixOS/nixpkgs
that referenced
this pull request
Feb 9, 2024
The build of `hh-suite` stopped working with GCC 13 because GCC stopped transitively including a couple of headers like `cstdint` in various scenarios. There already is an upstream PR proposed that fixes this issue [1] but hasn't been merged yet. This change pulls in this correction using `fetchpatch`, fixing the build for now. [1]: soedinglab/hh-suite#357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following header changes in gcc 13, hh-suite fails to build with the following errors:
Including cstdint in the affected file allows the build to go through. This issue has initially been reported in Debian bug #1037689.