[SofaExporter] Move bindings from SofaPython #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredroy
added
pr: fast merge
|
[ci-build][with-all-tests] |
marques-bruno
approved these changes
Jul 3, 2019
guparan
added
pr: status wip
| @@ -188,6 +187,7 @@ endif() | |||
| target_include_directories(${PROJECT_NAME} PUBLIC "$<BUILD_INTERFACE:${CMAKE_BINARY_DIR}/include>") | |||
| target_include_directories(${PROJECT_NAME} PUBLIC "$<BUILD_INTERFACE:${CMAKE_CURRENT_SOURCE_DIR}/..>") | |||
| target_include_directories(${PROJECT_NAME} PUBLIC "$<INSTALL_INTERFACE:include>") | |||
| set_target_properties(${PROJECT_NAME} PROPERTIES COMPILE_FLAGS "${SOFAPYTHON_COMPILER_FLAGS}") | |||
| set_target_properties(${PROJECT_NAME} PROPERTIES PUBLIC_HEADER "${HEADER_FILES}") | |||
There was a problem hiding this comment.
I don't want to be a bummer but... @guparan didn't we say we should remove all the PUBLIC_HEADER props?
There was a problem hiding this comment.
Yup, they have to go. It could also be done everywhere in a future PR.
fredroy
added
pr: status to review
guparan
approved these changes
Jul 9, 2019
hugtalbot
added
pr: status ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SofaPython could not compile without having SofaExporter.
To solve that, bindings included in SofaPython are moved into SofaExporter.
Bindings should be included into their respective modules/plugins anyway.
This PR:
Reviewers will merge only if all these checks are true.