Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SofaSimulationGraph] Stop DAGNode get parent topology process in BarycentricMapping #1176

Merged
merged 3 commits into from Oct 16, 2019
Merged

[SofaSimulationGraph] Stop DAGNode get parent topology process in BarycentricMapping #1176

merged 3 commits into from Oct 16, 2019

Conversation

adagolodjo
Copy link
Contributor

@adagolodjo adagolodjo commented Oct 9, 2019 •
edited by hugtalbot

Stop the search of the Container/BaseTopology when one is found (using break)

This PR:

  • builds with SUCCESS for all platforms on the CI.
  • does not generate new warnings.
  • does not generate new scene test failures.
  • does not generate new unit test failures.
  • does not break API compatibility.
  • is more than 1 week old (or has fast-merge label).

Reviewers will merge only if all these checks are true.

@adagolodjo adagolodjo added pr: fix Fix a bug issue: bug (minor) Bug affecting only some users or with no major impact on the framework labels Oct 9, 2019
@hugtalbot hugtalbot added the pr: status to review To notify reviewers to review this pull-request label Oct 9, 2019
@adagolodjo
Copy link
Contributor Author

Merci @hugtalbot, j'avais oublié de mettre "to review".

@hugtalbot
Copy link
Contributor

Hi @younesssss
If I understand correctly, you are preventing from the case SearchRoot
but could you explain how are you exactly "helping" in the BMapping getting the parent topo ?

@guparan guparan added pr: status ready Approved a pull-request, ready to be squashed and removed pr: status to review To notify reviewers to review this pull-request labels Oct 16, 2019
@hugtalbot hugtalbot changed the title [DAGNode] Help BarycentricMapping to get parent topology [DAGNode] Stop get parent topology process in BarycentricMapping Oct 16, 2019
@epernod epernod merged commit 8b9227b into sofa-framework:master Oct 16, 2019
@guparan guparan added this to the v19.12 milestone Jan 14, 2020
@guparan guparan changed the title [DAGNode] Stop get parent topology process in BarycentricMapping [SofaSimulationGraph] Stop DAGNode get parent topology process in BarycentricMapping Jan 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damienmarchal damienmarchal Awaiting requested review from damienmarchal

Assignees
No one assigned
Labels
issue: bug (minor) Bug affecting only some users or with no major impact on the framework pr: fix Fix a bug pr: status ready Approved a pull-request, ready to be squashed
Projects
None yet
Milestone
v19.12
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@adagolodjo @hugtalbot @guparan @epernod